- Notifications
You must be signed in to change notification settings - Fork22
chore!: remove deprecated items fromcoder_workspace data source#255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…urceThe owner-related fields (`owner`, `owner_email`, `owner_id`, `owner_name`, `owner_oidc_access_token`, `owner_groups`, `owner_session_token`) in the workspace data source have been deprecated. This commit removes these fields from the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
self review.
| @@ -13,11 +13,51 @@ Use this data source to get information for the active workspace build. | |||
| ## Example Usage | |||
| ```terraform | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Elaborated example usage. If its too much happy to simply it.
| @@ -36,7 +34,7 @@ resource "coder_env" "git_author_name" { | |||
| } | |||
| resource "coder_env" "git_author_email" { | |||
| agent_id =var.agent_id | |||
| agent_id =coder_agent.dev.id | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
there was no var defined so used the already defined agent.
| "workspace.owner": `testing`, | ||
| "workspace.owner_email": `testing@coder\.com`, | ||
| "workspace.owner_groups": `\[\]`, | ||
| "workspace.owner_id": `[a-zA-Z0-9]+`, | ||
| "workspace.owner_name": `default`, | ||
| "workspace.owner_oidc_access_token": `^$`, // TODO: need a test OIDC integration | ||
| "workspace.owner_session_token": `[a-zA-Z0-9-]+`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
removed all owner related items from the integration test. We already have a separate integration test forcoder_workspace_owner.
We will need to bump the major version after this change. |
7ed088d intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The owner-related fields (
owner,owner_email,owner_id,owner_name,owner_oidc_access_token,owner_groups,owner_session_token) in the workspace data source have been deprecated. This commit removes these fields from the codebase.We should have done this beforehttps://github.com/coder/terraform-provider-coder/releases/tag/v1.0.0
contributes to#250