Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: require environment variables#246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 2 commits intomainfrom13680-build-id
Jun 27, 2024
Merged

feat: require environment variables#246

mtojek merged 2 commits intomainfrom13680-build-id
Jun 27, 2024

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedJun 27, 2024•
edited
Loading

Fixes:#224
Related:coder/coder#13680

This PR enables constraint validation for required environment variables.

@mtojekmtojek self-assigned thisJun 27, 2024
@mtojekmtojek requested a review fromjohnstcnJune 27, 2024 08:04
@mtojekmtojek marked this pull request as ready for reviewJune 27, 2024 08:04
@mtojekmtojek requested a review fromstirbyJune 27, 2024 08:04
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you update the integration test as well?

@mtojek
Copy link
MemberAuthor

Yes, but I don't have a clue: how?

The integration test operates on Coder CLI, like e2e test, and this is an internal change. We would have to trick Coder to misbehave?

@johnstcn
Copy link
Member

Yeah, the more I look at this change, the less I can see an integration test being able to assert anything useful.

@mtojekmtojek merged commit9f66e78 intomainJun 27, 2024
12 checks passed
@mtojekmtojek deleted the 13680-build-id branchJune 27, 2024 09:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 27, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@stirbystirbyAwaiting requested review from stirby

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve version compatibility
2 participants
@mtojek@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp