feat: annotate resources with`SchemaVersion`#244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mtojek merged 11 commits intomainfrom224-version-comp

Jun 25, 2024

Merged

feat: annotate resources with`SchemaVersion`#244

mtojek merged 11 commits intomainfrom224-version-comp

Jun 25, 2024

Conversation

Copy link

Member

mtojek commentedJun 25, 2024•
edited
Loading

Related:#224

Changes:

setSchemaVersion to 1 (first revision). One this is done, we can useStateUpgraders to transform the resource state
implement helpers to handle environment variables in a unified way

Re FIXMEs (actually more important than this PR):

Coder provisioner usesterraform-plugin-coder in different contexts - a dry run, a template run, a workspace build, etc. We can't usehelpers.RequireEnv() in other modes than "workspace build", as the provisioner does not set these values (empty variable). If we switch tohelpers.RequireEnv() now, "template import" will fail due to unset env values.
We can implement a workaround by passing the extra env variableCODER_WORKSPACE_BUILD_ID=.... If this variable is set, the plugin should presence the required env values.