- Notifications
You must be signed in to change notification settings - Fork22
chore(docs): move coder_parameter example#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stirby commentedJun 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@mtojek I removed the
Since I couldn't find any errors in the output of
I also tried to add other resources to the All this said, I would actually like to take a stab at rewriting the Mind taking a look? |
For now, lazily duplicated resource examples test loop for data sources to test. |
mtojek commentedJun 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Alright, I think I made the CI happy now.
This may not be straightforward if examples depend on external fields or providers. For instance: EDIT: Let me know if this is ready to review, and I will re-check everything 👍 |
stirby commentedJun 25, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I did some reading of other providers. Rarely do code examples reference other providers but it feels essential for our examples like
Edit: trying one more thing. |
Ended up over complicating. Should be good for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
b73066b
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The
coder_parameter
data-source's code example was in theresources directory by mistake, moved.Fixes#242.
Curious what the failed
examples_test.go
looks like so intentionally ignored.