Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add integration test for provider#233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 7 commits intomainfromcj/provider-integration-tests
Jun 4, 2024

Conversation

johnstcn
Copy link
Member

This PR adds integration tests for the provider against an arbitrary version of Coder.

Example usage:

CODER_VERSION="v2.10.0-devel-3a9a7d199-amd64" go test -v ./integration

Testing methodology:

  • Create an ephemeral Coder instance running in a container
  • Perform initial setup
  • Import a predefined template that creates a single file
  • Create a workspace that populates the file with the actual output
  • Compare the actual versus expected output

matifali reacted with thumbs up emoji
@johnstcnjohnstcn self-assigned thisMay 28, 2024
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking super slick, added a few notes

@johnstcnjohnstcn marked this pull request as ready for reviewMay 29, 2024 09:17
}
}

// TODO: test coder_external_auth and coder_git_auth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

coder_git_auth could be skipped as it has been deprecated for a while.

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice testing improvement, so let's get it in.

@@ -0,0 +1,65 @@
terraform {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: curious if we can use a file from the examples directory, or put it there.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We could use some, but most have dependencies like gcloud credentials that we can't necessarily provide.

@johnstcn
Copy link
MemberAuthor

Will add to GitHub testing workflow in a separate PR.

@johnstcnjohnstcn merged commitdf75712 intomainJun 4, 2024
12 checks passed
@johnstcnjohnstcn deleted the cj/provider-integration-tests branchJune 4, 2024 09:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping left review comments

@matifalimatifalimatifali left review comments

@mtojekmtojekmtojek approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@johnstcn@dannykopping@matifali@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp