Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add coder_workspace_owner datasource#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 5 commits intomainfromcj/datasource_coder_user
May 24, 2024

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMay 23, 2024•
edited
Loading

NOTE: still needs some coder/coder changes.

Adds acoder_workspace_owner data source populated from all available information, if present.

Deprecates relevant fields ofcoder_workspace.

@johnstcnjohnstcn self-assigned thisMay 23, 2024
@johnstcnjohnstcnforce-pushed thecj/datasource_coder_user branch from1b8e938 to28bab5aCompareMay 24, 2024 08:25
@johnstcnjohnstcn marked this pull request as ready for reviewMay 24, 2024 08:52
@johnstcnjohnstcn changed the titlefeat: add coder_user datasourcefeat: add coder_workspace_owner datasourceMay 24, 2024
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM although deprecation path will be long...

@johnstcnjohnstcn merged commiteb43b9f intomainMay 24, 2024
12 checks passed
@johnstcnjohnstcn deleted the cj/datasource_coder_user branchMay 24, 2024 13:48
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 24, 2024
@matifali
Copy link
Member

@stirby if we are planning to remove all deprecated items in 1.0 then I suggest we should list them in a milestone or an ☔ issue.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@matifali@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp