- Notifications
You must be signed in to change notification settings - Fork22
fix: set owner name and email to "default"#209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Closes coder/modules#162When the terraform plan is run, the `data.coder_workspace.me.owner_email` and `data.coder_workspace.me.owner_name` fields are blank, which causes the template build to fail. This should resolve the issue by setting those entries to a non-empty string.Uh oh!
There was an error while loading.Please reload this page.
johnstcn left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should add a unit test to validate this behaviour, and we should probably also validate that this only happens during the plan phase; if these values are unset at the apply stage then this is a pretty big bug somewhere in the coder <-> provider interface.
I would be happy if someone could take this from here and add the tests. I opened this, considering its a smaller change. I am yet to feel confident about my Go skills. |
Closes coder/modules#162
When the terraform plan is run, the
data.coder_workspace.me.owner_emailanddata.coder_workspace.me.owner_namefields are blank, which causes the template build to fail.This should resolve the issue by setting those entries to a non-empty string.