- Notifications
You must be signed in to change notification settings - Fork22
fix!: add extra validation for start_blocks_login#192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mafredri merged 1 commit intomainfrommafredri/fix-add-extra-start-blocks-login-validationFeb 9, 2024
Merged
fix!: add extra validation for start_blocks_login#192
mafredri merged 1 commit intomainfrommafredri/fix-add-extra-start-blocks-login-validationFeb 9, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
johnstcn approved these changesFeb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm in favour of this change, as it will surface a misconfiguration to the user as opposed to it just silently not working.
dc08ac6 to59bcde6CompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally part of#191 but split out because it is a bit of a breaking change, but hopefully it will help users avoid confusion when one is set without the other and the feature doesn't work.
This guarantee also makes our coder/coder more correct since it's common pratice toonly look at
start_blocks_login.