- Notifications
You must be signed in to change notification settings - Fork22
fix: improve coder_script related docs#191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
provider/script.go Outdated
| if !runOnStart && startBlocksLogin { | ||
| return diag.Errorf("start_blocks_login can only be set if run_on_start is true") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does this extra check risk breaking any existing usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Possibly, but it also alerts users to a misconfiguration that will cause unexpected results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Might be worth calling this out as a potentially breaking change then. LGTM otherwise 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I broke it out to a separate PR, this was a good callout tbh:#192
1f7d0a3 to62c590dCompare
Uh oh!
There was an error while loading.Please reload this page.
fix: add extra validation for start_blocks_login(fix!: add extra validation for start_blocks_login #192)