Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Add app support#17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromdevurl
May 6, 2022
Merged

feat: Add app support#17

kylecarbs merged 1 commit intomainfromdevurl
May 6, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedMay 6, 2022
edited
Loading

This adds what are presently named "devurls" in v1.
It seems this is a dated term, since this allows
much more than accessing applications via URL.

"coder open " will launch any apps defined.
If in the web, it'll open either a web terminal or
port forward to the desired application. If in the terminal,
it'll open the browser, or launch the command over SSH.

@kylecarbskylecarbs requested a review frombpmctMay 6, 2022 01:29
@kylecarbskylecarbs self-assigned thisMay 6, 2022
@kylecarbskylecarbs requested a review fromcoadlerMay 6, 2022 02:02
kylecarbs added a commit to coder/coder that referenced this pull requestMay 6, 2022
This adds DevURLs as a property to a workspace agent.The resource is added to the Terraform provider here:coder/terraform-provider-coder#17DevURLs will be opened in the dashboard or via the CLIwith `coder open <name>`. If `command` is specified, aterminal will appear locally and in the web. If `target`is specified, the browser will open to an exposed instanceof that target.
@kylecarbskylecarbs mentioned this pull requestMay 6, 2022
3 tasks
### Optional

- `command` (String) A command to run in a terminal opening this DevURL. In the web, this will open in a new tab. In the CLI, this will SSH and execute the command.
- `icon` (String) An icon to display in the dashboard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This doesn't really explain how to use theicon. I see the examples all usebuiltin:x strings, is there a way to see all builtin icons? Is it possible to use a non-builtin icon?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

provider.coder.url + "/icons/goland.png"

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

data.coder_workspace.me.external_url

Description: "A URL to be proxied to from inside the workspace.",
ForceNew: true,
Optional: true,
ConflictsWith: []string{"command"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We don't seem to document theConflictsWith requirements at all.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

True. I shall fix!

This adds what are presently named "devurls" in v1.It seems this is a dated term, since this allowsmuch more than accessing applications via URL."coder open <name>" will launch any apps defined.If in the web, it'll open either a web terminal orport forward to the desired application. If in the terminal,it'll open the browser, or launch the command over SSH.
@kylecarbskylecarbs changed the titlefeat: Add DevURL supportfeat: Add app supportMay 6, 2022
@kylecarbskylecarbs merged commit4531753 intomainMay 6, 2022
@kylecarbskylecarbs deleted the devurl branchMay 6, 2022 17:16
kylecarbs added a commit to coder/coder that referenced this pull requestMay 6, 2022
This adds DevURLs as a property to a workspace agent.The resource is added to the Terraform provider here:coder/terraform-provider-coder#17DevURLs will be opened in the dashboard or via the CLIwith `coder open <name>`. If `command` is specified, aterminal will appear locally and in the web. If `target`is specified, the browser will open to an exposed instanceof that target.
kylecarbs added a commit to coder/coder that referenced this pull requestMay 6, 2022
This adds apps as a property to a workspace agent.The resource is added to the Terraform provider here:coder/terraform-provider-coder#17Apps will be opened in the dashboard or via the CLIwith `coder open <name>`. If `command` is specified, aterminal will appear locally and in the web. If `target`is specified, the browser will open to an exposed instanceof that target.
kylecarbs added a commit to coder/coder that referenced this pull requestJun 4, 2022
* feat: Add app supportThis adds apps as a property to a workspace agent.The resource is added to the Terraform provider here:coder/terraform-provider-coder#17Apps will be opened in the dashboard or via the CLIwith `coder open <name>`. If `command` is specified, aterminal will appear locally and in the web. If `target`is specified, the browser will open to an exposed instanceof that target.* Compare fields in apps test* Update Terraform provider to use relative path* Add some basic structure for routing* chore: Remove interface from coderd and lift API surfaceAbstracting coderd into an interface added misdirection becausethe interface was never intended to be fulfilled outside of a singleimplementation.This lifts the abstraction, and attaches all handlers to a root structnamed `*coderd.API`.* Add basic proxy logic* Add proxying based on path* Add app proxying for wildcards* Add wsconncache* fix: Race when writing to a closed pipeThis is such an intermittent race it's difficult to track,but regardless this is an improvement to the code.* fix: Race when writing to a closed pipeThis is such an intermittent race it's difficult to track,but regardless this is an improvement to the code.* fix: Race when writing to a closed pipeThis is such an intermittent race it's difficult to track,but regardless this is an improvement to the code.* fix: Race when writing to a closed pipeThis is such an intermittent race it's difficult to track,but regardless this is an improvement to the code.* Add workspace route proxying endpoint- Makes the workspace conn cache concurrency-safe- Reduces unnecessary open checks in `peer.Channel`- Fixes the use of a temporary context when dialing a workspace agent* Add embed errors* chore: Refactor site to improve testingIt was difficult to develop this package due to theembed build tag being mandatory on the tests. The logicto test doesn't require any embedded files.* Add test for error handler* Remove unused access url* Add RBAC tests* Fix dial agent syntax* Fix linting errors* Fix gen* Fix icon required* Adjust migration number* Fix proxy error status code* Fix empty db lookup
kylecarbs added a commit to coder/coder that referenced this pull requestJun 10, 2022
* feat: Add app supportThis adds apps as a property to a workspace agent.The resource is added to the Terraform provider here:coder/terraform-provider-coder#17Apps will be opened in the dashboard or via the CLIwith `coder open <name>`. If `command` is specified, aterminal will appear locally and in the web. If `target`is specified, the browser will open to an exposed instanceof that target.* Compare fields in apps test* Update Terraform provider to use relative path* Add some basic structure for routing* chore: Remove interface from coderd and lift API surfaceAbstracting coderd into an interface added misdirection becausethe interface was never intended to be fulfilled outside of a singleimplementation.This lifts the abstraction, and attaches all handlers to a root structnamed `*coderd.API`.* Add basic proxy logic* Add proxying based on path* Add app proxying for wildcards* Add wsconncache* fix: Race when writing to a closed pipeThis is such an intermittent race it's difficult to track,but regardless this is an improvement to the code.* fix: Race when writing to a closed pipeThis is such an intermittent race it's difficult to track,but regardless this is an improvement to the code.* fix: Race when writing to a closed pipeThis is such an intermittent race it's difficult to track,but regardless this is an improvement to the code.* fix: Race when writing to a closed pipeThis is such an intermittent race it's difficult to track,but regardless this is an improvement to the code.* Add workspace route proxying endpoint- Makes the workspace conn cache concurrency-safe- Reduces unnecessary open checks in `peer.Channel`- Fixes the use of a temporary context when dialing a workspace agent* Add embed errors* chore: Refactor site to improve testingIt was difficult to develop this package due to theembed build tag being mandatory on the tests. The logicto test doesn't require any embedded files.* Add test for error handler* Remove unused access url* Add RBAC tests* Fix dial agent syntax* Fix linting errors* Fix gen* Fix icon required* Adjust migration number* Fix proxy error status code* Fix empty db lookup
DanielleMaywood pushed a commit that referenced this pull requestSep 5, 2024
This adds what are presently named "devurls" in v1.It seems this is a dated term, since this allowsmuch more than accessing applications via URL."coder open <name>" will launch any apps defined.If in the web, it'll open either a web terminal orport forward to the desired application. If in the terminal,it'll open the browser, or launch the command over SSH.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coadlercoadlercoadler approved these changes

@bpmctbpmctbpmct approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@coadler@bpmct

[8]ページ先頭

©2009-2025 Movatter.jp