Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: addcoder_external_auth and deprecatecoder_git_auth#163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 2 commits intomainfromextauth
Oct 3, 2023

Conversation

kylecarbs
Copy link
Member

No description provided.

@kylecarbskylecarbs requested a review frombpmctOctober 3, 2023 14:45
@kylecarbskylecarbs self-assigned thisOct 3, 2023
// externalAuthDataSource returns a schema for an external authentication data source.
func externalAuthDataSource() *schema.Resource {
return &schema.Resource{
Description: "Use this data source to require users to authenticate with an external provider prior to workspace creation. This can be used to pre-authenticate external services in a workspace.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Description:"Use this data source to require users to authenticate with an externalprovider prior to workspace creation. This can be used to pre-authenticate external services in a workspace.",
Description:"Use this data source to require users to authenticate with an externalservice prior to workspace creation. This can be used to pre-authenticate external services in a workspace.",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

don't want to mix up things with terraform providers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we add an example with the gcloud CLI? I think the terms "provider" "service" and "application" would all be confusing as to what it actually does but one single example could go a long way.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sure

@bpmct
Copy link
Member

How is coder_git_auth deprecated? I don't see a message or anything?

@kylecarbs
Copy link
MemberAuthor

There's a deprecation message added to it. It should be displayed when used.

@kylecarbskylecarbs merged commitc31c582 intomainOct 3, 2023
@kylecarbskylecarbs deleted the extauth branchOctober 3, 2023 15:25
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bpmctbpmctbpmct approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kylecarbs@bpmct

[8]ページ先頭

©2009-2025 Movatter.jp