coder/terraform-provider-coderPublic

NotificationsYou must be signed in to change notification settings
Fork22
Star47

feat: add`default_apps` field to`coder_agent` resource#147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sreya merged 10 commits intomainfromjon/defaultapps

Aug 30, 2023

Merged

feat: add`default_apps` field to`coder_agent` resource#147

sreya merged 10 commits intomainfromjon/defaultapps

Aug 30, 2023

Conversation

Copy link

Collaborator

sreya commentedAug 14, 2023•
edited
Loading

Enables a template admin to configure which apps are displayed to the user in the dashboard.

fixes the provider side ofcoder/coder#8033

It takes the form

resource"coder_agent""dev" {os="linux"arch="amd64"display_apps {vscode=falsevscode_insiders=trueweb_terminal=falseport_forwarding_helper=falsessh_helper=false} }

If you do not add adisplay_apps block you opt-in to the defaults.
To opt out of all apps you must explicitly set them all tofalse.

feat: add default_apps field to agent

f14f186

- Enables a template admin to configure which apps are displayed  to the user in the dashboard.

matifali reviewed

Aug 15, 2023

View reviewed changes

docs/resources/agent.md OutdatedShow resolvedHide resolved

sreya added3 commits

August 23, 2023 01:10

update structure of display_apps

6354863

make geN

c526179

rm bad test

41f4ebd

sreya requested review fromkylecarbs andbpmct

August 23, 2023 01:18

kylecarbs approved these changes

Aug 23, 2023

View reviewed changes

mtojek reviewed

Aug 29, 2023

View reviewed changes

provider/agent.goShow resolvedHide resolved

provider/agent_test.go

		os = "linux"
		arch = "amd64"
		display_apps {
		vscode = false

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we need an extra test case to check .tf with only a few apps selected:

display_apps {   vscode = true   web_terminal = true

Copy link

CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since they all have default values I tested that specifying their non-defaults (inOK) and then omitting them to produce the defaults (inOmitted) produces the desired result. I added another one anyway but I don't think it adds much value.