- Notifications
You must be signed in to change notification settings - Fork22
chore: clarify the format ofurl forcoder_app resource#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
A user has suggested to clarify the format of `url` in `coder_app` resource.See :coder/coder#8574 (comment) for related discussion.
bpmct approved these changesJul 19, 2023
Member
mtojek commentedAug 10, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@matifali didn't bot complain about the typo in the PR title? EDIT: oh, most likely it is enabled only for coder/coder. |
Yes most probably. We should add cdr-bot here too. |
Taking a break from developing cdr-bot unless something urgent comes up. |
url forcoder_app resourceurl forcoder_app resourceSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user has suggested to clarify the format of
urlincoder_appresource.See :coder/coder#8574 (comment) for related discussion.