Jul 18, 2023 · Jul 18, 2023 · Jul 18, 2023 · Jul 18, 2023
diff --git a/examples/resources/coder_parameter/resource.tf b/examples/resources/coder_parameter/resource.tf
  name      = "Fairy Tale"
  type      = "string"
  mutable   = true
  default   = "Hansel and Gretel"
  ephemeral = true
 }

diff --git a/provider/parameter.go b/provider/parameter.go
 return diag.Errorf("parameter can't be immutable and ephemeral")
 }

 if !parameter.Optional && parameter.Ephemeral {
 return diag.Errorf("ephemeral parameter requires the default property")
 }

 if len(parameter.Validation) == 1 {
 validation := &parameter.Validation[0]
 err = validation.Valid(parameter.Type, value)
diff --git a/provider/parameter_test.go b/provider/parameter_test.go
 EOT
 mutable = true
 icon = "/icon/region.svg"
 default = "us-east1-a"
 option {
 name = "US Central"
 value = "us-central1-a"
 "option.1.icon":        "/icon/east.svg",
 "option.1.description": "Select for east!",
 "order":                "5",
 "default":              "us-east1-a",
 "ephemeral":            "true",
 } {
 require.Equal(t, value, attrs[key])
 data "coder_parameter" "region" {
 name = "Region"
 type = "string"
 default = "abc"
 mutable = false
 ephemeral = true
 }
 `,
 ExpectError: regexp.MustCompile("parameter can't be immutable and ephemeral"),
 }, {
 Name: "RequiredEphemeralError",
 Config: `
 data "coder_parameter" "region" {
 name = "Region"
 type = "string"
 mutable = true
 ephemeral = true
 }
 `,
 ExpectError: regexp.MustCompile("ephemeral parameter requires the default property"),
 }} {
 tc := tc
 t.Run(tc.Name, func(t *testing.T) {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -75,6 +75,7 @@ data "coder_parameter" "fairy_tale" {
		name = "Fairy Tale"
		type = "string"
		mutable = true
		default = "Hansel and Gretel"
		ephemeral = true
		}

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -134,6 +134,10 @@ func parameterDataSource() *schema.Resource {
		return diag.Errorf("parameter can't be immutable and ephemeral")
		}

		if !parameter.Optional && parameter.Ephemeral {
		return diag.Errorf("ephemeral parameter requires the default property")
Copy link Member mafredriJul 18, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Sanity check: do parameters have an optional field or is it inferred by setting default, and is that the only way to do it? (I always stop to ask when I see the check and message say something different.) Copy link MemberAuthor mtojekJul 18, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. do parameters have an optional field No. is it inferred by setting default Yes 👍 is that the only way to do it Yes 👍
		}

		if len(parameter.Validation) == 1 {
		validation := &parameter.Validation[0]
		err = validation.Valid(parameter.Type, value)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -31,6 +31,7 @@ func TestParameter(t *testing.T) {
		EOT
		mutable = true
		icon = "/icon/region.svg"
		default = "us-east1-a"
		option {
		name = "US Central"
		value = "us-central1-a"
Expand DownExpand Up		@@ -65,6 +66,7 @@ func TestParameter(t *testing.T) {
		"option.1.icon": "/icon/east.svg",
		"option.1.description": "Select for east!",
		"order": "5",
		"default": "us-east1-a",
		"ephemeral": "true",
		} {
		require.Equal(t, value, attrs[key])
Expand DownExpand Up		@@ -558,11 +560,23 @@ data "coder_parameter" "region" {
		data "coder_parameter" "region" {
		name = "Region"
		type = "string"
		default = "abc"
		mutable = false
		ephemeral = true
		}
		`,
		ExpectError: regexp.MustCompile("parameter can't be immutable and ephemeral"),
		}, {
		Name: "RequiredEphemeralError",
		Config: `
		data "coder_parameter" "region" {
		name = "Region"
		type = "string"
		mutable = true
		ephemeral = true
		}
		`,
		ExpectError: regexp.MustCompile("ephemeral parameter requires the default property"),
		}} {
		tc := tc
		t.Run(tc.Name, func(t *testing.T) {
Expand Down