- Notifications
You must be signed in to change notification settings - Fork23
feat: ephemeral parameters must be optional#141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
| } | ||
| if!parameter.Optional&¶meter.Ephemeral { | ||
| returndiag.Errorf("ephemeral parameter requires the default property") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sanity check: do parameters have an optional field or is it inferred by setting default, and is that the only way to do it? (I always stop to ask when I see the check and message say something different.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
do parameters have an optional field
No.
is it inferred by setting default
Yes 👍
is that the only way to do it
Yes 👍
Related:coder/coder#6828
This PR introduces another constraint for ephemeral parameters:
defaultproperty defined.