Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add order to coder_parameter#134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 5 commits intocoder:mainfrommtojek:8193-priority-ui
Jun 28, 2023

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedJun 27, 2023•
edited
Loading

Related:coder/coder#8193

This PR addsorder property tocoder_parameter to determine the position of parameters presented in the UI/CLI form. More details can be found in the related issue.

@mtojekmtojek self-assigned thisJun 27, 2023
@mtojekmtojek marked this pull request as ready for reviewJune 27, 2023 09:52
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good 👍🏻. Do we need a test to check it as well?

@mtojek
Copy link
MemberAuthor

Do we need a test to check it as well?

Done!

@mtojek
Copy link
MemberAuthor

mtojek commentedJun 28, 2023•
edited
Loading

I adjusted the PR to follow recentproduct expectations. Would you mind taking another look?

@mtojekmtojek changed the titlefeat: add priority to coder_parameterfeat: add order to coder_parameterJun 28, 2023
@mtojekmtojek merged commit09c3ada intocoder:mainJun 28, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 28, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@bpmctbpmctAwaiting requested review from bpmct

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mtojek@mafredri@spikecurtis
[8]ページ先頭
©2009-2025 Movatter.jp