Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add metadata block to the agent#112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ammario merged 4 commits intomainfromagent-metadata
Mar 31, 2023
Merged

Add metadata block to the agent#112

ammario merged 4 commits intomainfromagent-metadata
Mar 31, 2023

Conversation

ammario
Copy link
Member

No description provided.

@ammarioammarioforce-pushed theagent-metadata branch 2 times, most recently from099761d to2bcda81CompareMarch 15, 2023 00:03
@ammarioammario requested a review fromkylecarbsMarch 24, 2023 19:21
@ammarioammario marked this pull request as ready for reviewMarch 24, 2023 19:21
os = "linux"
arch = "amd64"
metadata {
key = "process_count"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thoughts on calling thisid instead? It's consistent with other naming we've done in here.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can make it id... We don't really want people thinking they have to auto generate it though.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Inresource_metadata, we usekey.

@ammarioammario merged commitbfa0c5a intomainMar 31, 2023
@ammarioammario deleted the agent-metadata branchMarch 31, 2023 18:20
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ammario@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp