- Notifications
You must be signed in to change notification settings - Fork22
feat: support list(string) as coder_parameter#111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| data "coder_parameter" "users" { | ||
| name = "System users" | ||
| type = "list(string)" | ||
| default = jsonencode(["root", "user1", "user2"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is really unfortunate, but we need to pick a single type of property. We need to fallback to string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it is ok just wondering iflist:string could be better to parse if we parse it at all. Just a thought, the current one looks good too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It would be definitely easier to parse, but it is aligned with Terraform now, so I'd rather keep like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Related:coder/coder#6582
This PR adds another supported type to
coder_parameter, a list of strings.