Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add confliction withsubdomain#469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jakehwll merged 13 commits intomainfromjakehwll/conflict-command-subdomain
Nov 29, 2025

Conversation

@jakehwll
Copy link
Contributor

@jakehwlljakehwll commentedNov 24, 2025•
edited
Loading

Addresses#343

This pull-request ensures that when we have acommand object key that it will conflict if we attempt to usesubdomain = true specified. This was previously an error back in July 2023, however it seems that we no longer actually throw a 500 if this doesn't exist, rather we simply ignore thesubdomain key.

For better overall handling we simply conflict against this now.

@jakehwlljakehwll marked this pull request as ready for reviewNovember 24, 2025 05:44
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 👍

@mtojek
Copy link
Member

@jakehwll Is it ready to merge, or are you still tinkering?

@jakehwll
Copy link
ContributorAuthor

@jakehwll Is it ready to merge, or are you still tinkering?

Need to remove the other duplicate test case! Will resolve in a few hours, happy otherwise

mtojek reacted with thumbs up emoji

@jakehwlljakehwll merged commit76bda72 intomainNov 29, 2025
6 checks passed
@jakehwlljakehwll deleted the jakehwll/conflict-command-subdomain branchNovember 29, 2025 10:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 29, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@matifalimatifalimatifali left review comments

@mtojekmtojekmtojek approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jakehwll@mtojek@matifali@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp