Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commite011f73

Browse files
committed
add unit test cases for previous values
1 parent9274e81 commite011f73

File tree

2 files changed

+126
-98
lines changed

2 files changed

+126
-98
lines changed

‎provider/parameter_test.go

Lines changed: 33 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -881,6 +881,7 @@ func TestParameterValidationEnforcement(t *testing.T) {
881881
OutputValuestring
882882
Optionalbool
883883
CreateError*regexp.Regexp
884+
Previous*string
884885
}
885886

886887
rows:=make([]row,0)
@@ -898,41 +899,44 @@ func TestParameterValidationEnforcement(t *testing.T) {
898899
continue// Skip rows with empty names
899900
}
900901

901-
optional,err:=strconv.ParseBool(columns[8])
902-
ifcolumns[8]!="" {
902+
cname,ctype,cprev,cinput,cdefault,coptions,cvalidation,_,coutput,coptional,cerr:=
903+
columns[0],columns[1],columns[2],columns[3],columns[4],columns[5],columns[6],columns[7],columns[8],columns[9],columns[10]
904+
905+
optional,err:=strconv.ParseBool(coptional)
906+
ifcoptional!="" {
903907
// Value does not matter if not specified
904908
require.NoError(t,err)
905909
}
906910

907911
varrerr*regexp.Regexp
908-
ifcolumns[9]!="" {
909-
rerr,err=regexp.Compile(columns[9])
912+
ifcerr!="" {
913+
rerr,err=regexp.Compile(cerr)
910914
iferr!=nil {
911-
t.Fatalf("failed to parse error column %q: %v",columns[9],err)
915+
t.Fatalf("failed to parse error column %q: %v",cerr,err)
912916
}
913917
}
914918

915919
varoptions []string
916-
ifcolumns[4]!="" {
917-
options=strings.Split(columns[4],",")
920+
ifcoptions!="" {
921+
options=strings.Split(coptions,",")
918922
}
919923

920924
varvalidation*provider.Validation
921-
ifcolumns[5]!="" {
925+
ifcvalidation!="" {
922926
switch {
923-
casecolumns[5]==provider.ValidationMonotonicIncreasing||columns[5]==provider.ValidationMonotonicDecreasing:
927+
casecvalidation==provider.ValidationMonotonicIncreasing||cvalidation==provider.ValidationMonotonicDecreasing:
924928
validation=&provider.Validation{
925929
MinDisabled:true,
926930
MaxDisabled:true,
927-
Monotonic:columns[5],
931+
Monotonic:cvalidation,
928932
Error:"monotonicity",
929933
}
930-
casevalidMinMax.MatchString(columns[5]):
934+
casevalidMinMax.MatchString(cvalidation):
931935
// Min-Max validation should look like:
932936
//1-10 :: min=1, max=10
933937
//-10 :: max=10
934938
//1- :: min=1
935-
parts:=strings.Split(columns[5],"-")
939+
parts:=strings.Split(cvalidation,"-")
936940
min,_:=strconv.ParseInt(parts[0],10,64)
937941
max,_:=strconv.ParseInt(parts[1],10,64)
938942
validation=&provider.Validation{
@@ -951,22 +955,30 @@ func TestParameterValidationEnforcement(t *testing.T) {
951955
Max:0,
952956
MaxDisabled:true,
953957
Monotonic:"",
954-
Regex:columns[5],
958+
Regex:cvalidation,
955959
Error:"regex error",
956960
}
957961
}
958962
}
959963

964+
varprev*string
965+
ifcprev!="" {
966+
prev=ptr(cprev)
967+
ifcprev==`""` {
968+
prev=ptr("")
969+
}
970+
}
960971
rows=append(rows,row{
961-
Name:columns[0],
962-
Types:strings.Split(columns[1],","),
963-
InputValue:columns[2],
964-
Default:columns[3],
972+
Name:cname,
973+
Types:strings.Split(ctype,","),
974+
InputValue:cinput,
975+
Default:cdefault,
965976
Options:options,
966977
Validation:validation,
967-
OutputValue:columns[7],
978+
OutputValue:coutput,
968979
Optional:optional,
969980
CreateError:rerr,
981+
Previous:prev,
970982
})
971983
}
972984

@@ -984,6 +996,9 @@ func TestParameterValidationEnforcement(t *testing.T) {
984996
ifrow.InputValue!="" {
985997
t.Setenv(provider.ParameterEnvironmentVariable("parameter"),row.InputValue)
986998
}
999+
ifrow.Previous!=nil {
1000+
t.Setenv(provider.ParameterEnvironmentVariablePrevious("parameter"),*row.Previous)
1001+
}
9871002

9881003
ifrow.CreateError!=nil&&row.OutputValue!="" {
9891004
t.Errorf("output value %q should not be set if both errors are set",row.OutputValue)

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp