Commit99ba884

authored

feat: addoptional property tocoder_external_auth (#185)

1 parent1797a03 commit99ba884Copy full SHA for 99ba884

File tree

+44

-1

lines changed

+44

-1

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,10 @@ Use this data source to require users to authenticate with an external service p`
`19`	`19`
`20`	`20`	-`id` (String) The ID of a configured external auth provider set up in your Coder deployment.
`21`	`21`
	`22`	`+###Optional`
	`23`	`+`
	`24`	+-`optional` (Boolean) Authenticating with the external auth provider is not required, and can be skipped by users when creating or updating workspaces
	`25`	`+`
`22`	`26`	`###Read-Only`
`23`	`27`
`24`	`28`	-`access_token` (String) The access token returned by the external auth provider. This can be used to pre-authenticate command-line tools.

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,13 @@ func externalAuthDataSource() *schema.Resource {`
`32`	`32`	`},`
`33`	`33`	`"access_token": {`
`34`	`34`	`Type:schema.TypeString,`
`35`		`-Computed:true,`
`36`	`35`	`Description:"The access token returned by the external auth provider. This can be used to pre-authenticate command-line tools.",`
	`36`	`+Computed:true,`
	`37`	`+},`
	`38`	`+"optional": {`
	`39`	`+Type:schema.TypeBool,`
	`40`	`+Description:"Authenticating with the external auth provider is not required, and can be skipped by users when creating or updating workspaces",`
	`41`	`+Optional:true,`
`37`	`42`	`},`
`38`	`43`	`},`
`39`	`44`	`}`

Lines changed: 34 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,40 @@ func TestExternalAuth(t *testing.T) {`
`36`	`36`
`37`	`37`	`attribs:=resource.Primary.Attributes`
`38`	`38`	`require.Equal(t,"github",attribs["id"])`
	`39`	`+require.Equal(t,"",attribs["optional"])`
	`40`	`+`
	`41`	`+returnnil`
	`42`	`+},`
	`43`	`+}},`
	`44`	`+})`
	`45`	`+}`
	`46`	`+`
	`47`	`+funcTestOptionalExternalAuth(t*testing.T) {`
	`48`	`+t.Parallel()`
	`49`	`+`
	`50`	`+resource.Test(t, resource.TestCase{`
	`51`	`+Providers:map[string]*schema.Provider{`
	`52`	`+"coder":provider.New(),`
	`53`	`+},`
	`54`	`+IsUnitTest:true,`
	`55`	`+Steps: []resource.TestStep{{`
	`56`	+Config:`
	`57`	`+provider "coder" {`
	`58`	`+}`
	`59`	`+data "coder_external_auth" "github" {`
	`60`	`+id = "github"`
	`61`	`+optional = true`
	`62`	`+}`
	`63`	+`,
	`64`	`+Check:func(state*terraform.State)error {`
	`65`	`+require.Len(t,state.Modules,1)`
	`66`	`+require.Len(t,state.Modules[0].Resources,1)`
	`67`	`+resource:=state.Modules[0].Resources["data.coder_external_auth.github"]`
	`68`	`+require.NotNil(t,resource)`
	`69`	`+`
	`70`	`+attribs:=resource.Primary.Attributes`
	`71`	`+require.Equal(t,"github",attribs["id"])`
	`72`	`+require.Equal(t,"true",attribs["optional"])`
`39`	`73`
`40`	`74`	`returnnil`
`41`	`75`	`},`

Comments

(0)