Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit7d258c1

Browse files
fix: add error detail for duplicate agent metadata key (#172)
* fix: add error detail for duplicate agent metadata key* Update provider/agent.goCo-authored-by: Mathias Fredriksson <mafredri@gmail.com>---------Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
1 parent0040c1d commit7d258c1

File tree

2 files changed

+50
-0
lines changed

2 files changed

+50
-0
lines changed

‎provider/agent.go‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
1212
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
1313
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
14+
"golang.org/x/xerrors"
1415
)
1516

1617
funcagentResource()*schema.Resource {
@@ -38,6 +39,19 @@ func agentResource() *schema.Resource {
3839
returndiag.FromErr(err)
3940
}
4041
}
42+
43+
rawPlan:=resourceData.GetRawPlan()
44+
items:=rawPlan.GetAttr("metadata").AsValueSlice()
45+
itemKeys:=map[string]struct{}{}
46+
for_,item:=rangeitems {
47+
key:=valueAsString(item.GetAttr("key"))
48+
_,exists:=itemKeys[key]
49+
ifexists {
50+
returndiag.FromErr(xerrors.Errorf("duplicate agent metadata key %q",key))
51+
}
52+
itemKeys[key]=struct{}{}
53+
}
54+
4155
returnupdateInitScript(resourceData,i)
4256
},
4357
ReadWithoutTimeout:func(ctx context.Context,resourceData*schema.ResourceData,iinterface{}) diag.Diagnostics {

‎provider/agent_test.go‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,42 @@ func TestAgent_Metadata(t *testing.T) {
250250
})
251251
}
252252

253+
funcTestAgent_MetadataDuplicateKeys(t*testing.T) {
254+
t.Parallel()
255+
resource.Test(t, resource.TestCase{
256+
Providers:map[string]*schema.Provider{
257+
"coder":provider.New(),
258+
},
259+
IsUnitTest:true,
260+
Steps: []resource.TestStep{{
261+
Config:`
262+
provider "coder" {
263+
url = "https://example.com"
264+
}
265+
resource "coder_agent" "dev" {
266+
os = "linux"
267+
arch = "amd64"
268+
metadata {
269+
key = "process_count"
270+
display_name = "Process Count"
271+
script = "ps aux | wc -l"
272+
interval = 5
273+
timeout = 1
274+
}
275+
metadata {
276+
key = "process_count"
277+
display_name = "Process Count"
278+
script = "ps aux | wc -l"
279+
interval = 5
280+
timeout = 1
281+
}
282+
}
283+
`,
284+
ExpectError:regexp.MustCompile("duplicate agent metadata key"),
285+
}},
286+
})
287+
}
288+
253289
funcTestAgent_DisplayApps(t*testing.T) {
254290
t.Parallel()
255291
t.Run("OK",func(t*testing.T) {

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp