Commit2f64d4c

authored

fix: show correct min and max values in validation errors (#122)

1 parent946db5a commit2f64d4cCopy full SHA for 2f64d4c

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -438,10 +438,10 @@ func (v *Validation) Valid(typ, value string) error {`
`438`	`438`	`returnfmt.Errorf("value %q is not a number",value)`
`439`	`439`	`}`
`440`	`440`	`ifv.Min!=nil&&num<*v.Min {`
`441`		`-returnfmt.Errorf("value %d is less than the minimum %d",num,v.Min)`
	`441`	`+returnfmt.Errorf("value %d is less than the minimum %d",num,*v.Min)`
`442`	`442`	`}`
`443`	`443`	`ifv.Max!=nil&&num>*v.Max {`
`444`		`-returnfmt.Errorf("value %d is more than the maximum %d",num,v.Max)`
	`444`	`+returnfmt.Errorf("value %d is more than the maximum %d",num,*v.Max)`
`445`	`445`	`}`
`446`	`446`	`ifv.Monotonic!=""&&v.Monotonic!=ValidationMonotonicIncreasing&&v.Monotonic!=ValidationMonotonicDecreasing {`
`447`	`447`	`returnfmt.Errorf("number monotonicity can be either %q or %q",ValidationMonotonicIncreasing,ValidationMonotonicDecreasing)`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -499,13 +499,13 @@ func TestValueValidatesType(t *testing.T) {`
`499`	`499`	`Type:"number",`
`500`	`500`	`Value:"0",`
`501`	`501`	`Min:ptrNumber(1),`
`502`		`-Error:regexp.MustCompile("is less than the minimum"),`
	`502`	`+Error:regexp.MustCompile("is less than the minimum 1"),`
`503`	`503`	`}, {`
`504`	`504`	`Name:"NumberAboveMax",`
`505`	`505`	`Type:"number",`
`506`	`506`	`Value:"2",`
`507`	`507`	`Max:ptrNumber(1),`
`508`		`-Error:regexp.MustCompile("is more than the maximum"),`
	`508`	`+Error:regexp.MustCompile("is more than the maximum 1"),`
`509`	`509`	`}, {`
`510`	`510`	`Name:"InvalidBool",`
`511`	`511`	`Type:"bool",`

Comments

(0)