- Notifications
You must be signed in to change notification settings - Fork215
GitBash and MinGW support#132
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Is this still being worked on? The hardcoded Meanwhile, sshcode seems to work on WSL now other than a few small hiccups. |
Merith-TK commentedSep 17, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It is being worked on, i am slowly working on a home detector, seehttps://github.com/Merith-TK/Personal-Projects/blob/master/Home.go Also school started a few weeks ago and i have been basically swamped. and i cant even test it at school during lunch because they blocked ssh... for some stupid reason MOST RECENT PUSH FIXED THE ISSUE |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
In that case we should just add a section to the README which says what env variable to use depending on git bash or msys. |
Merith-TK commentedApr 8, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I still don't want to rewrite the entire path fixing function but I am working on it since the F***ing coronavirus has canceled my plans. EDIT, i am running EDIT2: I am ready to throw my computer out the window |
one second, need to undo a personal modification |
Don't know whats going on with the current Travis build for you guys, but the build for me is working... |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
kylejbrk commentedApr 10, 2020
Any updates on this? Looking forward if this can run via Gitbash/Windows. |
My fork is completely functional for gitbash, msys2, and mingw. You can clone my repo in its current state and build it yourself if you like |
Dont know what broke travis for you guys, but it passes on my end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some of my earlier reviews haven't been fixed properly.
Please re-request a review when you want this to be reviewed and merged. I don't read most of my github emails because I get too many, but I get a notification on slack if I'm requested for review. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
I can't merge this automatically because of glitch with travis. The build passed on travis but didn't get reported to github. I'll squash and merge this manually tomorrow. |
Alright, hope people find this useful! |
Supports git bash and mingw on Windows. Does not support cmd.exe.Signed-off-by: Dean Sheather <dean@deansheather.com>Co-authored-by: Merith <merith.tk@gmail.com>
Squashed and merged via50e859c |
Uh oh!
There was an error while loading.Please reload this page.
TL;DR
ensureDir()
Summary of Edits
Progress
https://user-images.githubusercontent.com/10422110/61765201-ef1c0e80-ad90-11e9-87cb-b46e6dc2a909.gif
https://user-images.githubusercontent.com/10422110/62153007-8533c580-b2b8-11e9-9d2b-03e25af9bbd0.gif
https://user-images.githubusercontent.com/10422110/62803352-094b3180-ba9f-11e9-818f-4c4b93fb60ed.gif
https://user-images.githubusercontent.com/10422110/63072181-48cab100-bed7-11e9-9d4b-97d7799e95fe.gif
https://user-images.githubusercontent.com/10422110/65101607-70e97c00-d97d-11e9-8eed-56205ad3e5b3.gif
ensureDir()
Rev 1: finally got it through travis.breaks windows support,Latest Build:
ensureDir()
/Workspace
,Workspace
,~/Workspace
,Workspace/