Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 17, 2021. It is now read-only.
/sshcodePublic archive

GitBash and MinGW support#132

Closed
Merith-TK wants to merge30 commits intocoder:masterfromMerith-TK:msys-support
Closed

GitBash and MinGW support#132

Merith-TK wants to merge30 commits intocoder:masterfromMerith-TK:msys-support

Conversation

Merith-TK
Copy link
Contributor

@Merith-TKMerith-TK commentedAug 15, 2019
edited
Loading

TL;DR

Summary of Edits

  • Fixed file pathing for windows client
  • Fixed ghost path creation on windows client
  • Added check to fix variables when using windows clients

Progress

Latest Build:

  • Resolving paths is now fully functional.
  • Ghost paths are no longer created on the client, (bug with patches toensureDir()
  • The following formats now work for opening remote paths,/Workspace,Workspace,~/Workspace,Workspace/
  • Code cleanup

@deansheather
Copy link
Member

Is this still being worked on? The hardcodedC:\mingw64 thing is still an issue. Would like to merge this soon.

Meanwhile, sshcode seems to work on WSL now other than a few small hiccups.

@Merith-TK
Copy link
ContributorAuthor

Merith-TK commentedSep 17, 2019
edited
Loading

It is being worked on, i am slowly working on a home detector, seehttps://github.com/Merith-TK/Personal-Projects/blob/master/Home.go

Also school started a few weeks ago and i have been basically swamped. and i cant even test it at school during lunch because they blocked ssh... for some stupid reason

MOST RECENT PUSH FIXED THE ISSUE

@deansheather
Copy link
Member

In that case we should just add a section to the README which says what env variable to use depending on git bash or msys.

IngCr3at1on reacted with thumbs up emoji

@Merith-TK
Copy link
ContributorAuthor

Merith-TK commentedApr 8, 2020
edited
Loading

I still don't want to rewrite the entire path fixing function but I am working on it since the F***ing coronavirus has canceled my plans.
https://cdn.merith.tk/workspace/merith/go-sshcode/sshcode.go
2020-04-07 20:22:10 INFO Resolved windows path 'C:/msys64/Workspace' to '/msys64/Workspace
is where I am at at the moment,
What would be helpful is a command likewinpath in wsl. because that thing you feed it a unix path, it will give the windows equivilant

EDIT, i am runningsshcode.exe developer@192.168.0.115 --skipsync /Workspace

EDIT2: I am ready to throw my computer out the window
{ cd / && pwd -W; } | sed 's|/|\\|g' returnsC:\Program Files\Git on gitbash
andC:\msys64\ on msys

@Merith-TK
Copy link
ContributorAuthor

one second, need to undo a personal modification

@Merith-TK
Copy link
ContributorAuthor

Don't know whats going on with the current Travis build for you guys, but the build for me is working...
https://travis-ci.org/github/Merith-TK/sshcode

@kylejbrk
Copy link

Any updates on this? Looking forward if this can run via Gitbash/Windows.

@Merith-TK
Copy link
ContributorAuthor

@kylejbrk

Any updates on this? Looking forward if this can run via Gitbash/Windows.

My fork is completely functional for gitbash, msys2, and mingw.
waiting on it to be merged

You can clone my repo in its current state and build it yourself if you like

@Merith-TK
Copy link
ContributorAuthor

Dont know what broke travis for you guys, but it passes on my end
https://travis-ci.org/github/Merith-TK/sshcode

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some of my earlier reviews haven't been fixed properly.

@deansheather
Copy link
Member

Please re-request a review when you want this to be reviewed and merged. I don't read most of my github emails because I get too many, but I get a notification on slack if I'm requested for review.

Merith-TK reacted with thumbs up emoji

@deansheather
Copy link
Member

I can't merge this automatically because of glitch with travis. The build passed on travis but didn't get reported to github. I'll squash and merge this manually tomorrow.

@Merith-TK
Copy link
ContributorAuthor

Alright, hope people find this useful!

deansheather added a commit that referenced this pull requestApr 27, 2020
Supports git bash and mingw on Windows. Does not support cmd.exe.Signed-off-by: Dean Sheather <dean@deansheather.com>Co-authored-by: Merith <merith.tk@gmail.com>
@deansheather
Copy link
Member

Squashed and merged via50e859c

@Merith-TKMerith-TK deleted the msys-support branchMay 2, 2020 22:51
@Merith-TKMerith-TK restored the msys-support branchMay 2, 2020 22:52
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

2 more reviewers

@IngCr3at1onIngCr3at1onIngCr3at1on left review comments

@deansheatherdeansheatherdeansheather approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Merith-TK@deansheather@eargollo@kylejbrk@IngCr3at1on

[8]ページ先頭

©2009-2025 Movatter.jp