- Notifications
You must be signed in to change notification settings - Fork215
Windows#118
Windows#118
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't have Windows so I'm unable to test the code, but it looks OK other than this.
| // Downloads the latest code-server and allows it to be executed. | ||
| sshCmdStr:=fmt.Sprintf("ssh %v %v '/usr/bin/env bash'",o.sshFlags,host) | ||
| // sshCmdStr := fmt.Sprintf("ssh %v %v /bin/bash -l", o.sshFlags, host) | ||
| sshCmdStr:=fmt.Sprintf("ssh %v %v '/usr/bin/env bash -l'",o.sshFlags,host) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The login shell stuff should be in a separate PR as it's unrelated to Git Bash for Windows support.
| sshCmdStr:=fmt.Sprintf("ssh %v %v '/usr/bin/env bash -l'",o.sshFlags,host) | ||
| sshCmd:=exec.Command("sh","-c",sshCmdStr) | ||
| sshCmd:=exec.Command("sh","-l","-c",sshCmdStr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
SSH is called from more places than just this, so if we're going to changesh to a login shell so it reads the profile we should also do this every else.
Closing this one to submit two separate PR's. Thanks for comments. |
Uh oh!
There was an error while loading.Please reload this page.
.profile