- Notifications
You must be signed in to change notification settings - Fork72
Add ray dashboard module#424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Adds Ray Dashboard integration for Coder workspaces with configurable options for port, sharing, and display settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds a new Ray Dashboard module that provides integration of Ray.io distributed computing dashboard into Coder workspaces. The module creates a Coder app resource with configurable options for port, sharing, and health checking.
- Creates a new Terraform module for Ray Dashboard integration
- Provides configurable variables for customizing the dashboard app behavior
- Includes proper versioning and metadata files for module management
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/ray-dashboard/coder/versions.yaml | Version configuration for the module |
| modules/ray-dashboard/coder/versions.tf | Terraform version requirements |
| modules/ray-dashboard/coder/variables.tf | Input variables for module configuration |
| modules/ray-dashboard/coder/outputs.tf | Output values from the module |
| modules/ray-dashboard/coder/metadata.yaml | Module metadata in YAML format |
| modules/ray-dashboard/coder/metadata.json | Module metadata in JSON format |
| modules/ray-dashboard/coder/main.tf | Main Terraform resource definitions |
| modules/ray-dashboard/coder/REAMDME.md | Documentation for the module |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@matifali Not sure what i need to do for this failing CI test |
@DevelopmentCats can you take a look? |
@DevelopmentCats@matifali think we're good |
Reviewing now |
@michaelvp411, we can move it to |
I would take a look at the Contribution docs. The file structure is bit off, and we have everything split up in and outside of the module folder. We would want this living in a folder: registry/coder/modules/ray-dashboard Typically modules have: Also something I noticed when looking through the module in segments, is that there is no working logic for installing or configuring ray-dashboard. Here is the reference for ray-dashboard:https://docs.ray.io/en/latest/ray-observability/getting-started.html Here is the reference for contributing:https://github.com/coder/registry/blob/main/CONTRIBUTING.md#creating-a-new-module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we should add these to the git-ignore so they dont get commit on accident.
Closes #
Description
Adds a new Ray Dashboard module that provides easy integration of Ray.io distributed computing dashboard into Coder workspaces. The module creates a Ray Dashboard app with health checks and configurable options for port, sharing, and display settings.
Type of Change
Module Information
Path:
modules/ray-dashboard/coderNew version:
v1.0.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun run fmt)Related Issues
None