- Notifications
You must be signed in to change notification settings - Fork72
feat(agentapi): add enable_tasks variable to conditionally create coder_ai_task resource#413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
blink-so wants to merge3 commits intomainChoose a base branch fromblink/agentapi-enable-tasks
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…er_ai_task resourceThis allows users to disable AI task creation when using the agentapi modulewith count = 0, avoiding the validation requirement for 'AI Prompt' parameter.When enable_tasks = false, the coder_ai_task resource will not be created,allowing the module to be used without defining the required AI Prompt parameter.
Remove extra space before comment to match prettier formatting rules.
Terraform fmt requires consistent spacing in resource blocks.
❌ Version Bump Validation FailedBump Type: Module versions need to be updated but haven't been bumped yet. Required Actions:
Script Output:
|
I'll try to run the claude-code module with these changes, and then merge this. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
enable_tasks
variable to the agentapi module that allows users to conditionally create thecoder_ai_task
resource.Problem
When using the agentapi module with
count = 0
at the module level, Terraform still validates all resources inside the module during the planning phase. This causes validation errors because thecoder_ai_task
resource requires an "AI Prompt" parameter to be defined in the template, even when the module won't be instantiated.Solution
enable_tasks
boolean variable (defaults totrue
for backward compatibility)count = var.enable_tasks ? 1 : 0
to thecoder_ai_task
resourceUsage
When
enable_tasks = false
, thecoder_ai_task
resource will not be created, avoiding the validation requirement for the "AI Prompt" parameter.Testing
Tested locally - the changes maintain backward compatibility (defaults to
true
) and resolve the validation issue when set tofalse
.