- Notifications
You must be signed in to change notification settings - Fork72
feat: add JFrog Xray vulnerability scanning module#410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
blink-so wants to merge7 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+370 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adds a Terraform module that integrates JFrog Xray vulnerability scanningresults into Coder workspace metadata. The module:- Fetches vulnerability scan results from JFrog Xray- Displays vulnerability counts (Critical, High, Medium, Low) on workspace page- Supports flexible image path formats- Works with any workspace type using container images- Provides secure token handlingResolvescoder/coder#12838 and addresses#65Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Fixes CI formatting checks for the JFrog Xray module.
Adds the required Terraform usage example immediately after the h1 headingto satisfy the README validation requirements.
Fixes remaining formatting issues in the README file.
The check_license argument is not supported by the JFrog Xray Terraformprovider, causing test failures. Removing this argument fixes theTerraform validation.
Adds proper null handling for cases where xray scan results are null,which was causing Terraform validation failures. Uses try() functionto gracefully handle null values and provide default vulnerability counts.
Fixes terraform formatting issue identified by CI checks.
@jatcod3r can you help me test this if you have s setup ready? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new Terraform module that integrates JFrog Xray vulnerability scanning results into Coder workspace metadata.
Features
Usage
Related Issues
Tested with basic Terraform validation. Full integration testing requires live JFrog instance.