Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: amp upgrades for better ux#390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
35C4n0r wants to merge17 commits intocoder:main
base:main
Choose a base branch
Loading
from35C4n0r:feat-amp-version

Conversation

35C4n0r
Copy link
Collaborator

@35C4n0r35C4n0r commentedAug 26, 2025
edited
Loading

Closes #

Description

  • remove default node installation
  • users can pass amp versions now
  • move env variables to terraform variable (system prompt and ai prompt)

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path:registry/coder-labs/modules/sourcegraph-amp
New version:v2.0.0
Breaking change: [x] Yes [ ] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

Copy link
Contributor

@DevelopmentCatsDevelopmentCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Left a few comments.

I'm going to pull and test this.

Copy link
Contributor

@DevelopmentCatsDevelopmentCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

I'm cool with the shift in variable standards in Agent Modules, I just wanted to make sure this was intentional.

@DevelopmentCats
Copy link
Contributor

I'm testing this out, and everything seemed fine at first glance@35C4n0r

But I notice that the permissions are not permissive enough for the docker tasks template, and it ends up stopping to ask the user for permissions to use tools.

Ideally we want this to work for tasks out of the box, and then the configuration would be updated by the user if they desire different behavior. Much like how the claude-code module works for tasks without needing to update the whole base config.

It might also be useful to link the docs for amp permissions in the README

image

Comment on lines +26 to 32
functioncheck_dependencies() {
if! command_exists node;then
printf"Error: Node.js is not installed. Please install Node.js manually or use the pre_install_script to install it.\n"
exit 1
fi

if! command_exists npm;then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's switch to using the install script.

curl -fsSL https://ampcode.com/install.sh | bash

https://ampcode.com/manual#getting-started-command-line-interface

DevelopmentCats reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DevelopmentCatsDevelopmentCatsDevelopmentCats approved these changes

@matifalimatifalimatifali requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@35C4n0r35C4n0r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@35C4n0r@DevelopmentCats@matifali

[8]ページ先頭

©2009-2025 Movatter.jp