- Notifications
You must be signed in to change notification settings - Fork72
feat: amp upgrades for better ux#390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Left a few comments.
I'm going to pull and test this.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
I'm cool with the shift in variable standards in Agent Modules, I just wanted to make sure this was intentional.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Atif Ali <me@matifali.dev>
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
I'm testing this out, and everything seemed fine at first glance@35C4n0r But I notice that the permissions are not permissive enough for the docker tasks template, and it ends up stopping to ask the user for permissions to use tools. Ideally we want this to work for tasks out of the box, and then the configuration would be updated by the user if they desire different behavior. Much like how the claude-code module works for tasks without needing to update the whole base config. It might also be useful to link the docs for amp permissions in the README ![]() |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
functioncheck_dependencies() { | ||
if! command_exists node;then | ||
printf"Error: Node.js is not installed. Please install Node.js manually or use the pre_install_script to install it.\n" | ||
exit 1 | ||
fi | ||
if! command_exists npm;then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's switch to using the install script.
curl -fsSL https://ampcode.com/install.sh | bash
https://ampcode.com/manual#getting-started-command-line-interface
Uh oh!
There was an error while loading.Please reload this page.
Closes #
Description
Type of Change
Module Information
Path:
registry/coder-labs/modules/sourcegraph-amp
New version:
v2.0.0
Breaking change: [x] Yes [ ] No
Testing & Validation
bun test
)bun run fmt
)Related Issues