Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: addvscode-desktop-core module#278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 17 commits intomainfromphorcys420/centralize-vscode-desktop
Aug 11, 2025

Conversation

phorcys420
Copy link
Member

@phorcys420phorcys420 commentedJul 31, 2025•
edited
Loading

This PR introduces a newvscode-desktop-core module that acts similarly as AgentAPI does for other modules as an effort to centralize the logic.

This will help with avoiding maintaining multiple modules that do the same thing. I will follow shortly with a PR for avscode-web-core module to centralize the logic forvscode-web andcode-server as we've had issues where both would behave differently due to forgetting to update one or the other.

This will also help make the amount of effort lower if we ever need to implement a module for another vendor (or if a community member does).

Modules update in#279
Part of WL-27

@phorcys420phorcys420 marked this pull request as ready for reviewAugust 1, 2025 15:31
@phorcys420phorcys420 self-assigned thisAug 1, 2025
matifali
matifali previously approved these changesAug 3, 2025
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot@phorcys420. This will significantly enhance the DevEX for module development and maintenance.

@phorcys420phorcys420enabled auto-merge (squash)August 4, 2025 09:24
@phorcys420phorcys420 requested a review frombpmctAugust 4, 2025 09:24
@matifali
Copy link
Member

Thoughts on adding MCP server support?
We can add a generic input namedmcp_config andmcp_path, which we can use from browser modules.

Here are a few examples

  1. Windsurf:/Users/matifali/.codeium/windsurf/mcp_config.json
  2. Cursor:~/.cursor/mcp.json
  3. VS Code: Didn't find a user specfic setting path

@phorcys420
Copy link
MemberAuthor

@matifali I want to add aconfig (and maybeextensions) entry in a next PR like we have for thecode-server module, I think it should solve that.

@matifali
Copy link
Member

Nice. But I think exposing MCPs separately would make more sense given how popular they are.

phorcys420 reacted with thumbs up emoji

Co-authored-by: Atif Ali <atif@coder.com>
@CopilotCopilotAI review requested due to automatic review settingsAugust 11, 2025 16:02
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR introduces a newvscode-desktop-core module to centralize VSCode desktop IDE logic across multiple modules, acting as a building block similar to how AgentAPI functions for other modules. This effort aims to reduce code duplication and maintenance burden.

  • Creates a core Terraform module for VSCode desktop IDE functionality
  • Provides a reusable foundation for VSCode-based IDE modules
  • Includes comprehensive test coverage and documentation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

FileDescription
registry/coder/modules/vscode-desktop-core/main.tfCore Terraform module implementation with variables, data sources, and coder_app resource
registry/coder/modules/vscode-desktop-core/main.test.tsComprehensive test suite covering various configuration scenarios
registry/coder/modules/vscode-desktop-core/README.mdDocumentation with usage examples and caution about direct usage

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@matifalimatifalienabled auto-merge (squash)August 11, 2025 16:20
@matifalimatifali merged commit63d56ea intomainAug 11, 2025
4 checks passed
@matifalimatifali deleted the phorcys420/centralize-vscode-desktop branchAugust 11, 2025 16:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@matifalimatifalimatifali approved these changes

@DevelopmentCatsDevelopmentCatsAwaiting requested review from DevelopmentCats

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@phorcys420phorcys420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@phorcys420@matifali
[8]ページ先頭
©2009-2025 Movatter.jp