Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on May 15, 2025. It is now read-only.
/modulesPublic archive

feat: add Amazon DCV Windows module#345

Merged
matifali merged 5 commits intomainfromatif/windows-dcv
Nov 27, 2024
Merged

Conversation

@matifali
Copy link
Member

@matifalimatifali commentedNov 20, 2024•
edited
Loading

Adds Amazon DCV for Windows workspaces.

Closes #344 along withcoder/coder#15610

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 suggestion.

Files not reviewed (2)
  • amazon-dcv-windows/install-dcv.ps1: Language not supported
  • amazon-dcv-windows/main.tf: Language not supported

@matifalimatifali requested a review frombpmctNovember 20, 2024 17:37
@matifalimatifaliforce-pushed theatif/windows-dcv branch 2 times, most recently from8b1bd8d to016481dCompareNovember 20, 2024 18:00
- Introduce Amazon DCV for remote desktop on Windows workspaces.- Script to install and configure DCV components.- Terraform setup for configuring resources like coder_app.- Ensure secure management with sensitive variable handling.chore: add health check badge (#341)chore: integrate Instatus in check script (#342)
Comment on lines +11 to +13
# Amazon DCV Windows

Amazon DCV is high performance remote display protocol that provides a secure way to deliver remote desktop and application streaming from any cloud or data center to any device, over varying network conditions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we add a nice screenshot or GIF for marketing purposes?

matifali reacted with thumbs up emoji
Copy link
MemberAuthor

@matifalimatifaliNov 20, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Forgot to add it, added now.

tags: [windows, dcv, web, desktop]
---

# Amazon DCV Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For non AWS workspaces, does this work OK?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes. I tested it on GCP, and it works. You will see a notification about getting the license, though.

bpmct reacted with thumbs up emoji
- Include visualization in README with new image- Change icon path in Terraform configuration for DCV
@bpmct
Copy link
Member

Are we good to merge?

matifali reacted with thumbs up emoji

@matifalimatifali merged commitb345e62 intomainNov 27, 2024
2 checks passed
@matifalimatifali deleted the atif/windows-dcv branchNovember 27, 2024 05:29
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

Copilot code reviewCopilotCopilot left review comments

@the-dietcoke-ofevilthe-dietcoke-ofevilAwaiting requested review from the-dietcoke-ofevil

+1 more reviewer

@bpmctbpmctbpmct approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matifalimatifali

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Amazon DCV Windows Integration

2 participants

@matifali@bpmct
[8]ページ先頭
©2009-2025 Movatter.jp