Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

impl: add the option to disable ssh wildcard configuration#584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 9 commits intomainfromimpl-support-for-disabling-wildcard-config
Oct 1, 2025

Conversation

fioan89
Copy link
Collaborator

It will be used later by the Coder Settings view to allow users to enable or disable SSH hostname wildcard configuration.

github-actions[bot] reacted with thumbs up emoji
It will be used later by the Coder Settings view to allow usersto enable or disable SSH hostname wildcard configuration.
Updated the UI component to allow configuration by the user
when generating the ssh config for Coder Gateway.Up until now we just checked if the Coder deployment supportsthis feature, but now users have to option to continue touse expanded hostnames in the ssh config.
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedSep 29, 2025
edited
Loading

Qodana Community for JVM

34 new problems were found

Inspection nameSeverityProblems
Usage of API marked for removal🔴 Failure13
Local 'var' is never modified and can be declared as 'val'🔶 Warning1
Incorrect string capitalization🔶 Warning1
Constant conditions🔶 Warning1
Usage of redundant or deprecated syntax or deprecated symbols🔶 Warning1
Throwable not thrown🔶 Warning1
Redundant nullable return type🔶 Warning1
Unused symbol🔶 Warning1
Convert 'object' to 'data object'◽️ Notice5
Class member can have 'private' visibility◽️ Notice3
String concatenation that can be converted to string template◽️ Notice2
Argument could be converted to 'Set' to improve performance◽️ Notice1
@Deprecated annotation without 'replaceWith' argument◽️ Notice1
Return or assignment can be lifted out◽️ Notice1
Redundant lambda arrow◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

CLIManager can be created with default settings (simplifies testing),among which the ssh wildcard config is enabled. But in reality theconfig can be disabled by the user.
…rd config was changedCurrently, if a user starts a connection with wildcard enabled and then later on it disablesthe wildcard config then the recent connections becomes unusable because the hostnames are invalid.The issue can reproduce the other way around as well (start with wildcard ssh config disabled,start an IDE and then later on enable wildcard config)This commit addresses the issue by resolving the hostname on demand when the user wants toopen the remote IDE from the recent connections panel.
@fioan89fioan89 marked this pull request as ready for reviewSeptember 30, 2025 20:29
Connections started with two different hostnames (because of the ssh wildcard config)can be rendered twice in the Recent projects panel.With this commit we ignore the hostname and instead use the workspace name and deployment URL.
Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me!

Do we know why users want this? I figured wildcard would always be better.

@fioan89
Copy link
CollaboratorAuthor

Looks good to me!

Do we know why users want this? I figured wildcard would always be better.

There is apparently a client that has issues with wildcard config, "After the SSH configuration changes introduced with jetbrains-coder in Version 2.18 (f39e1f4) we are no longer able to connect JetBrains Gateway to our workspaces (Failed to retrieve IDEs / Host is unknown)."

They requested a way to disable the wildcard configuration. Probably it makes more sense to understand the issue they have with this configuration but unfortunately they haven't provided any logs. And on the other hand, Coder Toolbox already provides both options (wildcard enabled or disabled)

@fioan89fioan89 merged commitaab5916 intomainOct 1, 2025
6 checks passed
@fioan89fioan89 deleted the impl-support-for-disabling-wildcard-config branchOctober 1, 2025 22:16
@code-asher
Copy link
Member

Ahh gotcha that makes sense!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@code-ashercode-ashercode-asher approved these changes

@f0sself0sselAwaiting requested review from f0ssel

@jcjiangjcjiangAwaiting requested review from jcjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@fioan89@code-asher

[8]ページ先頭

©2009-2025 Movatter.jp