Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: relaxed SNI hostname resolution#579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 3 commits intomainfromrelaxed-sni-resolution
Sep 19, 2025
Merged

Conversation

fioan89
Copy link
Collaborator

@fioan89fioan89 commentedSep 17, 2025•
edited
Loading

When establishing TLS connections, SNI resolution may fail if the configured altHostname contains_ or any other characters not allowed by domain name standards (i.e. letters, digits and hyphens).

This change introduces a relaxed SNI resolution strategy which ignores the LDH rules completely. Because this change goes hand in hand with auth. via certificates, I was able to reproduce the issue only via UTs. At this point the official Coder releases supports only auth. via API keys.

github-actions[bot] reacted with thumbs up emoji
When establishing TLS connections, SNI resolution may fail if the configured altHostname contains `_` orany other characters not allowed by domain name standards (i.e. letters, digits and hyphens).This change introduces a relaxed SNI resolution strategy which ignores the LDH rules completely.Because this change goes hand in hand with auth. via certificates, I was able to reproduce the issueonly via UTs. At this point the official Coder releases supports only auth. via API keys.-fixes#577
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedSep 17, 2025•
edited
Loading

Qodana Community for JVM

33 new problems were found

Inspection nameSeverityProblems
Usage of API marked for removal🔴 Failure13
Local 'var' is never modified and can be declared as 'val'🔶 Warning1
Incorrect string capitalization🔶 Warning1
Constant conditions🔶 Warning1
Usage of redundant or deprecated syntax or deprecated symbols🔶 Warning1
Throwable not thrown🔶 Warning1
Redundant nullable return type🔶 Warning1
Unused symbol🔶 Warning1
Convert 'object' to 'data object'◽️ Notice5
Class member can have 'private' visibility◽️ Notice3
String concatenation that can be converted to string template◽️ Notice2
Argument could be converted to 'Set' to improve performance◽️ Notice1
Return or assignment can be lifted out◽️ Notice1
Redundant lambda arrow◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

@fioan89fioan89 merged commitb7b609d intomainSep 19, 2025
6 checks passed
@fioan89fioan89 deleted the relaxed-sni-resolution branchSeptember 19, 2025 07:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@code-ashercode-ashercode-asher approved these changes

@matifalimatifaliAwaiting requested review from matifali

@f0sself0sselAwaiting requested review from f0ssel

@jcjiangjcjiangAwaiting requested review from jcjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underscores not allowed in "Alt hostname" configuration parameter
2 participants
@fioan89@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp