- Notifications
You must be signed in to change notification settings - Fork16
impl: verify cli signature#562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is the key that validates if the gpg signature was tampered
For one thing some method signature changed, some methods are now suspending functionsthat will have to run in a coroutine in the tests. The second big issue is that nowthe download function requests user's input via a dialog
github-actionsbot commentedJul 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Qodana Community for JVM33 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true Contact Qodana teamContact us atqodana-support@jetbrains.com
|
The signature for windows CLI follows the format: coder-windows-amd64.exe.ascCurrently it is coded to coder-windows-amd64.asc which means the pluginalways fail to find any signature for windows cli
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure about the URL issue but looks good to me.
This commit rejects any URL that is opaque, not hierarchical, not using http or httpsprotocol, or it misses the hostname.
This commit rejects any URL that is opaque, not hierarchical, not using http or httpsprotocol, or it misses the hostname.
jdomeracki-coder left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looking good!
0164c60
intomainUh oh!
There was an error while loading.Please reload this page.
Is there any setting to disable this new check? We distribute a custom build of the CLI, so this is popping up for all our users and is quite confusing/disruptive. |
This PR introduces support for verifying the CLI binary using a detached PGP signature. Starting with version 2.24, Coder signs all CLI binaries. For clients using older versions or running Gateway in air-gapped environments, unsigned CLIs can still be executed — but users will have to confirm it each time.
In terms of code changes - the PR includes a big refactor around CLI downloading with most of the code refactored and extracted in various components that provide clean steps and result state in the main download method. Then the pgp verification logic was added on top, with some particularities:
This PR is a backport ofcoder/coder-jetbrains-toolbox#148