- Notifications
You must be signed in to change notification settings - Fork16
feat: set 'jetbrains_connection' as build reason on workspace start#561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Qodana Community for JVM23 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true Contact Qodana teamContact us atqodana-support@jetbrains.com
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
This PR introduces new build reason values to identify what type ofconnection triggered a workspace build, helping to troubleshootworkspace-related issues.## Database MigrationAdded migration 000349_extend_workspace_build_reason.up.sql that extendsthe build_reason enum with new values:```dashboard, cli, ssh_connection, vscode_connection, jetbrains_connection```## ImplementationThe build reason is specified through the API when creating newworkspace builds:- Dashboard: Automatically sets reason to `dashboard` when users startworkspaces via the web interface- CLI `start` command: Sets reason to `cli` when workspaces are startedvia the command line- CLI `ssh` command: Sets reason to ssh_connection when workspaces arestarted due to SSH connections- VS Code connections: Will be set to `vscode_connection` by the VS Codeextension through CLI hidden flag(coder/vscode-coder#550)- JetBrains connections: Will be set to `jetbrains_connection` by theJetbrains Toolbox(coder/coder-jetbrains-toolbox#150) andJetbrains Gateway extension(coder/jetbrains-coder#561)## UI Changes:* Tooltip with reason in Build history<img width="309" height="457" alt="image"src="https://github.com/user-attachments/assets/bde8440b-bf3b-49a1-a244-ed7e8eb9763c"/>* Reason in Audit Logs Row tooltip<img width="906" height="237" alt="image"src="https://github.com/user-attachments/assets/ebbb62c7-cf07-4398-afbf-323c83fb6426"/><img width="909" height="188" alt="image"src="https://github.com/user-attachments/assets/1ddbab07-44bf-4dee-8867-b4e2cd56ae96"/>
3c8828d
intomainUh oh!
There was an error while loading.Please reload this page.
This PR is part ofcoder/coder#18827 which introduces new build reason values to identify what type of connection triggered a workspace build, helping to troubleshoot workspace-related issues.