Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: set 'jetbrains_connection' as build reason on workspace start#561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kacpersaw merged 2 commits intomainfromkacpersaw/build-reason
Jul 22, 2025

Conversation

kacpersaw
Copy link
Contributor

This PR is part ofcoder/coder#18827 which introduces new build reason values to identify what type of connection triggered a workspace build, helping to troubleshoot workspace-related issues.

github-actions[bot] reacted with thumbs up emoji
@github-actionsGitHub Actions
Copy link
Contributor

Qodana Community for JVM

23 new problems were found

Inspection nameSeverityProblems
Usage of API marked for removal🔴 Failure13
Local 'var' is never modified and can be declared as 'val'🔶 Warning1
Incorrect string capitalization🔶 Warning1
Constant conditions🔶 Warning1
Usage of redundant or deprecated syntax or deprecated symbols🔶 Warning1
Redundant nullable return type🔶 Warning1
String concatenation that can be converted to string template◽️ Notice2
Argument could be converted to 'Set' to improve performance◽️ Notice1
Class member can have 'private' visibility◽️ Notice1
Redundant lambda arrow◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

Copy link
Collaborator

@fioan89fioan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

kacpersaw added a commit to coder/coder that referenced this pull requestJul 22, 2025
This PR introduces new build reason values to identify what type ofconnection triggered a workspace build, helping to troubleshootworkspace-related issues.## Database MigrationAdded migration 000349_extend_workspace_build_reason.up.sql that extendsthe build_reason enum with new values:```dashboard, cli, ssh_connection, vscode_connection, jetbrains_connection```## ImplementationThe build reason is specified through the API when creating newworkspace builds:- Dashboard: Automatically sets reason to `dashboard` when users startworkspaces via the web interface- CLI `start` command: Sets reason to `cli` when workspaces are startedvia the command line- CLI `ssh` command: Sets reason to ssh_connection when workspaces arestarted due to SSH connections- VS Code connections: Will be set to `vscode_connection` by the VS Codeextension through CLI hidden flag(coder/vscode-coder#550)- JetBrains connections: Will be set to `jetbrains_connection` by theJetbrains Toolbox(coder/coder-jetbrains-toolbox#150) andJetbrains Gateway extension(coder/jetbrains-coder#561)## UI Changes:* Tooltip with reason in Build history<img width="309" height="457" alt="image"src="https://github.com/user-attachments/assets/bde8440b-bf3b-49a1-a244-ed7e8eb9763c"/>* Reason in Audit Logs Row tooltip<img width="906" height="237" alt="image"src="https://github.com/user-attachments/assets/ebbb62c7-cf07-4398-afbf-323c83fb6426"/><img width="909" height="188" alt="image"src="https://github.com/user-attachments/assets/1ddbab07-44bf-4dee-8867-b4e2cd56ae96"/>
@kacpersawkacpersaw merged commit3c8828d intomainJul 22, 2025
6 checks passed
@kacpersawkacpersaw deleted the kacpersaw/build-reason branchJuly 22, 2025 11:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fioan89fioan89fioan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kacpersaw@fioan89

[8]ページ先頭

©2009-2025 Movatter.jp