Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: pass the folder parameter to the IDE&Project dialog#550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fioan89 merged 3 commits intomainfromfix-url-handler-ignores-folder-param
May 20, 2025

Conversation

fioan89
Copy link
Collaborator

The value of thefolder URI parameter is passed to the IDE&Project dialog when handling URIs. The folder value will be rendered instead of the default home folder if the value is not blank.

I've also changed the list of Gateway versions we run the verifier against to include Gateway 2025.1 while excluding some ancient releases.Without this commit the PR will fail to build, the declared snapshots are no longer available in the repository
-resolves#466

github-actions[bot] reacted with thumbs up emoji
I've also changed the list of Gateway versions we run the verifier againstto include Gateway 2025.1 while excluding some ancient releases.Without this commit the PR will fail to build, the declared snapshots areno longer available in the repository
The value of the `folder` URI parameter is passed to the IDE&Projectdialog when handling URIs. The folder value will be rendered insteadof the default home folder if the value is not blank.-resolves#466
@fioan89fioan89 requested review frommatifali andf0sselMay 15, 2025 21:35
@fioan89
Copy link
CollaboratorAuthor

I'll also push a new release once this PR is merged.

image

@github-actionsGitHub Actions
Copy link
Contributor

Qodana Community for JVM

23 new problems were found

Inspection nameSeverityProblems
Usage of API marked for removal🔴 Failure13
Local 'var' is never modified and can be declared as 'val'🔶 Warning1
Incorrect string capitalization🔶 Warning1
Constant conditions🔶 Warning1
Usage of redundant or deprecated syntax or deprecated symbols🔶 Warning1
Redundant nullable return type🔶 Warning1
String concatenation that can be converted to string template◽️ Notice2
Argument could be converted to 'Set' to improve performance◽️ Notice1
Class member can have 'private' visibility◽️ Notice1
Redundant lambda arrow◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. There are a few warnings saying, we are using some marked for removal libraries
image

@@ -4,10 +4,10 @@ pluginGroup=com.coder.gateway
# Zip file name.
pluginName=coder-gateway
# SemVer format -> https://semver.org
pluginVersion=2.20.0
pluginVersion=2.20.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As we are dropping support for the minimum version, what do you think about bumping the minor version?
@code-asher, how have we done it historically?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We're not dropping support for the minimum version — we're just building with a newer snapshot because that's what's available in the snapshot repositories. I've updated the versions we test the plugin against in GitHub workflows and locally. Since we’re no longer using any new Gateway APIs, I think it’s unnecessary to keep verifying against so many older versions.

matifali reacted with thumbs up emoji
@fioan89fioan89 requested a review fromcode-asherMay 19, 2025 13:35
Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, not sure why we were not doing this before!

@fioan89fioan89 merged commit708bc6b intomainMay 20, 2025
6 checks passed
@fioan89fioan89 deleted the fix-url-handler-ignores-folder-param branchMay 20, 2025 07:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifalimatifali left review comments

@code-ashercode-ashercode-asher approved these changes

@f0sself0sselAwaiting requested review from f0ssel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL handler ignores folder parameter when IDE is unspecified
3 participants
@fioan89@matifali@code-asher

[8]ページ先頭

©2009-2025 Movatter.jp