- Notifications
You must be signed in to change notification settings - Fork16
fix: pass the folder parameter to the IDE&Project dialog#550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I've also changed the list of Gateway versions we run the verifier againstto include Gateway 2025.1 while excluding some ancient releases.Without this commit the PR will fail to build, the declared snapshots areno longer available in the repository
The value of the `folder` URI parameter is passed to the IDE&Projectdialog when handling URIs. The folder value will be rendered insteadof the default home folder if the value is not blank.-resolves#466
Qodana Community for JVM23 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true Contact Qodana teamContact us atqodana-support@jetbrains.com
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@@ -4,10 +4,10 @@ pluginGroup=com.coder.gateway | |||
# Zip file name. | |||
pluginName=coder-gateway | |||
# SemVer format -> https://semver.org | |||
pluginVersion=2.20.0 | |||
pluginVersion=2.20.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As we are dropping support for the minimum version, what do you think about bumping the minor version?
@code-asher, how have we done it historically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We're not dropping support for the minimum version — we're just building with a newer snapshot because that's what's available in the snapshot repositories. I've updated the versions we test the plugin against in GitHub workflows and locally. Since we’re no longer using any new Gateway APIs, I think it’s unnecessary to keep verifying against so many older versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, not sure why we were not doing this before!
708bc6b
intomainUh oh!
There was an error while loading.Please reload this page.
The value of the
folder
URI parameter is passed to the IDE&Project dialog when handling URIs. The folder value will be rendered instead of the default home folder if the value is not blank.I've also changed the list of Gateway versions we run the verifier against to include Gateway 2025.1 while excluding some ancient releases.Without this commit the PR will fail to build, the declared snapshots are no longer available in the repository
-resolves#466