- Notifications
You must be signed in to change notification settings - Fork16
impl: support for unlimited 'Until Build' setting#549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This upgrade is needed in order to be able to upgrade the gateway/intellijplatform plugins.
This is needed in order to be able to specify "unlimited until builds".IntelliJ Platform Gradle Plugin 2.x is the build system that supersedesthe Gradle IntelliJ Plugin 1.x, and this is the version that comes withthe ability to provide unlimited until build support.This is a major overhaul of the DSL, I've tested these changes locally withGW 2023.3 (the minimum supported version), and I've also compared the plugin.xmlwith a previous version to make sure it is generated correctly.
Every time a new GW version is released we need to change the untilBuild setting.With latest IntelliJ Platform Plugin we can provide unlimited upper range with nomanual intervention each time a new release is happening.
matifali left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, although the PR does more than just make the until version unlimited. It may be better to extract the refactoring to another PR.
It is a valid point, my thinking was that they could go in one shot because the upgrade to Platform plugin 2.x is mandatory. |
Use gateway DSL to provide the platform type and version.The plugin verification as well as the platform type depends on the versions in the format "2025.x"
We don't have any UI tests but the test task still fails because it misses junit 4 dependencies.For the unit tests we use kotlin tests library with junit 5 as a backend.
listProductsReleases was renamed to printProductsReleases in version 2.x
github-actionsbot commentedJun 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Qodana Community for JVM23 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true Contact Qodana teamContact us atqodana-support@jetbrains.com
|
8467b89 intomainUh oh!
There was an error while loading.Please reload this page.
Every time a new GW version is released we need to change the untilBuild setting. With latest IntelliJ Platform Plugin we can provide unlimited upper range with no manual intervention each time a new release is happening.
IntelliJ Platform Gradle Plugin 2.x is the build system that supersedes the Gradle IntelliJ Plugin 1.x, and this is the version that comes with the ability to provide unlimited until build support.
This is a major overhaul of the DSL, I've tested these changes locally with GW 2023.3 (the minimum supported version), and I've also compared the plugin.xml with a previous version to make sure it is generated correctly.