- Notifications
You must be signed in to change notification settings - Fork16
[WIP ]Toolbox ramp up#532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- toolbox can't load the plugin because of serialization issues.- backgroundColors is no longer recognized
- include latest 2.6.0 builds
github-actionsbot commentedFeb 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Qodana Community for JVM16 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true Contact Qodana teamContact us atqodana-support@jetbrains.com
|
- needed to build plugins for toolbox 2.6.0
- removed gateway api's no longer available in Toolbox 2.6.0- replaced it with a couple of new toolbox api libraries
- removed gateway api's no longer available in Toolbox 2.6.0- replaced it with a couple of new toolbox api libraries
- updated KSP to match Kotlin version- removed unused dependencies
- to reflect the new toolbox api
@fioan89 hello! |
Sure, sorry about that. |
Don't be! I'm communicating it for the first time now 💀 |
- to reflect the new toolbox api
- like core-api, ui-api, remote-dev-api which should no longer be packaged.
- okhttp is no longer provided by Toolbox- with this commit we package our own libraries
- slf4j runtime is no longer provided by Toolbox- the sample code promotes the usage of service locator to resolve a logger. However, this approach has a couple of downsides, mainly it tightly couples all layers of code because the service locator needs to be propagated from the dev extension down to the lowest level of coder business implementation.- instead, we now pack tinylog with slf4j bindings to avoid classloading issues.
- quality of life improvement to automate some recurring manual tasks like cleaning up the plugin install dir
- without the need to go through a "field accessor"- fixes some NPE when reading the url
Initial skeleton for Coder integration with JetBrains Toolbox- the code is imported from coder/jetbrains-coder-coder/jetbrains-coder#532 can provide a betterview on the major changes compared with gateway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry for the delay on getting to this. I'm going to try and free up more time this week to collaborate@fioan89
no worries. This is a stale PR, I think I'll close it. Most of the action now happens athttps://github.com/coder/coder-jetbrains-toolbox-plugin |
Work in progress to make the plugin load in the latest Toolbox versions (2.6.0).