coder/jetbrains-coderPublic

NotificationsYou must be signed in to change notification settings
Fork16
Star33

Initial impl of defaultIde selection setting#522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bcpeinhardt merged 5 commits intomainfrombcpeinhardt/set-default-ide-version-in-dropdown

Jan 17, 2025

Merged

Initial impl of defaultIde selection setting#522

bcpeinhardt merged 5 commits intomainfrombcpeinhardt/set-default-ide-version-in-dropdown

Jan 17, 2025

Conversation

Copy link

Contributor

bcpeinhardt commentedJan 14, 2025

No description provided.

Initial impl of defaultIde selection setting

1ba763b

bcpeinhardt commented

Jan 14, 2025

View reviewed changes

CONTRIBUTING.md Outdated


		```
		./gradlew clean runIDE --args="jetbrains-gateway://connect#type=coder&workspace=dev&agent=coder&folder=/home/coder&url=https://dev.coder.com&token=<redacted>&ide_product_code=IU&ide_build_number=223.8836.41&ide_download_link=https://download.jetbrains.com/idea/ideaIU-2022.3.3.tar.gz"
		./gradlew clean runIDE --args="jetbrains-gateway://connect#type=coder&workspace=bcpeinhardt&owner=benpeinhardt&agent=dev&folder=/home/coder&url=https://dev.coder.com&token=<redacted>"

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll change this back when I'm done messing with it.

Copy link

Contributor

github-actionsbot commentedJan 14, 2025•
edited
Loading

Qodana Community for JVM

5 new problems were found

Inspection name	Severity	Problems
`Incorrect string capitalization`	🔶 Warning	1
`Redundant nullable return type`	🔶 Warning	1
`String concatenation that can be converted to string template`	◽️ Notice	2
`Redundant lambda arrow`	◽️ Notice	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register atQodana Cloud andconfigure the action
UseGitHub Code Scanning with Qodana
HostQodana report at GitHub Pages
Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true

Contact Qodana team

Or via our issue tracker:https://jb.gg/qodana-issue
Or share your feedback:https://jb.gg/qodana-discussions

bcpeinhardt requested a review fromcode-asher

January 15, 2025 16:02

Copy link

ContributorAuthor

bcpeinhardt commentedJan 15, 2025

@code-asher I'm not actually sure what the best way to test this is 🤔

Reset example url in readme

5ba242c

bcpeinhardt marked this pull request as ready for review

January 17, 2025 19:12

code-asher approved these changes

Jan 17, 2025

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to me!

src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspaceProjectIDEStepView.kt Outdated

		importcom.jetbrains.gateway.ssh.IntelliJPlatformProduct
		importcom.jetbrains.gateway.ssh.deploy.DeployException
		importcom.jetbrains.gateway.ssh.util.validateRemotePath
		importcom.jetbrains.rd.generator.nova.PredefinedType

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You probably already see the warning but appears to be unused (I thinkktlint will delete unused imports if you want to try using that)

src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspaceProjectIDEStepView.kt Outdated

		// Using contains on the displayable version of the ide means they can be as specific or as vague as they want
		// CL 2023.3.6 233.15619.8 -> a specific Clion build
		// CL 2023.3.6 -> a specific Clion version
		// 2023.3.6 -> a specific version (some customers will on have one specific IDE in their list anyway)

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Typo I think inwill on have (will only have maybe)

src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspaceProjectIDEStepView.kt

		)

		// Check the provided setting to see if there's a default IDE to set.
		val defaultIde= ides.find { it->

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Qodana will complain aboutit -> since that is the default, although idk how much we should care about Qodana. Possiblyktlint would change this automatically.

Tangent, but I think there is an alias forfind calledfirstOrNull. Kinda surprised there is noindexOfFirstOrNull, onlyindexOfFirst.indexOfFirst().takeIf { it >= 0 } would work around that I guess.

Anyway, no need to change to those, more that I nerd sniped myself. 😆

src/main/kotlin/com/coder/gateway/CoderSettingsConfigurable.kt Outdated

		row(CoderGatewayBundle.message("gateway.connector.settings.default-ide")) {
		textField().resizableColumn().align(AlignX.FILL)
		.bindText(state::defaultIde)
		.comment("The default IDE version to display in the IDE selection dropdown."+

Copy link

Member

code-asherJan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wonder if we need to make mention that JetBrains by default only shows the latest version (latest stable and latest EAP I think, right?), so as soon as JetBrains updates their list this setting may become obsolete unless they are using just the IDE name or year.

But, maybe this option will only be used by folks that have provided their own list instead of fetching from JetBrains, so that might not be an issue.

Copy link

Member

code-asher commentedJan 17, 2025•
edited
Loading

I'm not actually sure what the best way to test this is 🤔

I think we have no way to test this view really, but I suppose one could extract the list model and test that part. I did a similar thing with the workspace selection list.

bcpeinhardt added3 commits

January 17, 2025 16:05

Selected KT Lint changes.

cc260fa

Fix typo.

2214c99

Update changelog.

7d76e4f

bcpeinhardt merged commitd27a65e intomain

Jan 17, 2025

6 checks passed

bcpeinhardt deleted the bcpeinhardt/set-default-ide-version-in-dropdown branch

January 17, 2025 22:26

Labels

None yet

Movatterモバイル変換

Initial impl of defaultIde selection setting#522

Initial impl of defaultIde selection setting#522

Uh oh!

Conversation

bcpeinhardt commentedJan 14, 2025

Uh oh!

bcpeinhardtJan 14, 2025

Choose a reason for hiding this comment

Uh oh!

github-actionsbot commentedJan 14, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Qodana Community for JVM

Uh oh!

bcpeinhardt commentedJan 15, 2025

Uh oh!

code-asher left a comment

Choose a reason for hiding this comment

Uh oh!

code-asherJan 17, 2025

Choose a reason for hiding this comment

Uh oh!

code-asherJan 17, 2025

Choose a reason for hiding this comment

Uh oh!

code-asherJan 17, 2025

Choose a reason for hiding this comment

Uh oh!

code-asherJan 17, 2025

Choose a reason for hiding this comment

Uh oh!

code-asher commentedJan 17, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actionsbot commentedJan 14, 2025•
edited
Loading

code-asher commentedJan 17, 2025•
edited
Loading