- Notifications
You must be signed in to change notification settings - Fork16
Use wildcard SSH config Host entries#521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Looks good so far 😎 |
This simplifies the written SSH config and avoids the need to make anAPI request for every workspace the filter returns. This can removeminutes from the "Configuring Coder CLI..." step when the user hasaccess to many workspaces (for example, an admin who wants the option ofconnecting to anyone's workspace on a large deployment).Depends oncoder/coder#16088
I think this is ready for review. The Coder CLI version number placeholder just needs to be filled in when that release happens. |
The necessary changes were released in Coder 2.19.0, so this is ready to go now. |
| @@ -4,6 +4,10 @@ | |||
| ## Unreleased | |||
| ### Changed | |||
| - Simplifies the written SSH config and avoids the need to make an API request for every workspace the filter returns. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
f39e1f4 intocoder:mainUh oh!
There was an error while loading.Please reload this page.
This simplifies the written SSH config and avoids the need to make an API request for every workspace the filter returns. This can remove minutes from the "Configuring Coder CLI..." step when the user has access to many workspaces (for example, an admin who wants the option of connecting to anyone's workspace on a large deployment).
Depends oncoder/coder#16088