- Notifications
You must be signed in to change notification settings - Fork16
[toolbox] Add workspace actions#486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
11700bd
to73f9e72
Compare73f9e72
to36d871a
Comparegithub-actionsbot commentedSep 24, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Qodana Community for JVM16 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true Contact Qodana teamContact us atqodana-support@jetbrains.com
|
You can now start, stop, and update workspaces. Since you can startworkspaces yourself now, I marked non-ready states as unreachable, whichprevents JetBrains from overriding with their own text ("disconnected"and "connected"). So now you will be able to see "stopped", "starting",and so on. For the ready states you will still see "disconnected" or"connected" unfortunately. Ideally this would be a completely separatestate displayed next to the workspace state.
36d871a
to5e52f91
Compare547fdea
intoasher/toolboxUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
You can now start, stop, and update workspaces. Since you can start workspaces yourself now, I marked non-ready states as unreachable, which prevents JetBrains from overriding with their own text ("disconnected" and "connected"). So now you will be able to see "stopped", "starting", and so on, which is nice. For the ready states you will still see "disconnected" or "connected" unfortunately. Ideally this would be displayed separately from the workspace state. This also means you have two clicks instead of one to connect to a workspace, but I felt like it was worth the tradeoff to (mostly) see the actual workspace state, and it does match the current Gateway flow. If we can separate the states visually then we can bring back the one-click behavior.
Weirdly, you can still press connect when environments are unreachable, but this will not actually work. It does not actually even attempt to connect, because if it did the workspace would start via the cli, so it seems to just be a no-op. Not sure what the idea here is, we may have to consult JetBrains.
Stacked on#487, for the CI fixes.
Closes#485