Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[toolbox] Add workspace actions#486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedSep 23, 2024
edited
Loading

You can now start, stop, and update workspaces. Since you can start workspaces yourself now, I marked non-ready states as unreachable, which prevents JetBrains from overriding with their own text ("disconnected" and "connected"). So now you will be able to see "stopped", "starting", and so on, which is nice. For the ready states you will still see "disconnected" or "connected" unfortunately. Ideally this would be displayed separately from the workspace state. This also means you have two clicks instead of one to connect to a workspace, but I felt like it was worth the tradeoff to (mostly) see the actual workspace state, and it does match the current Gateway flow. If we can separate the states visually then we can bring back the one-click behavior.

Weirdly, you can still press connect when environments are unreachable, but this will not actually work. It does not actually even attempt to connect, because if it did the workspace would start via the cli, so it seems to just be a no-op. Not sure what the idea here is, we may have to consult JetBrains.

Stacked on#487, for the CI fixes.

Closes#485

github-actions[bot] reacted with thumbs up emoji
@code-ashercode-asherforce-pushed theasher/toolbox-dev/workspace-actions branch 2 times, most recently from11700bd to73f9e72CompareSeptember 23, 2024 23:30
@code-ashercode-asher changed the base branch fromasher/toolbox toasher/toolbox-dev/ciSeptember 24, 2024 00:08
@code-ashercode-asherforce-pushed theasher/toolbox-dev/workspace-actions branch from73f9e72 to36d871aCompareSeptember 24, 2024 00:11
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedSep 24, 2024
edited
Loading

Qodana Community for JVM

16 new problems were found

Inspection nameSeverityProblems
Unused symbol🔶 Warning11
Class member can have 'private' visibility◽️ Notice3
String concatenation that can be converted to string template◽️ Notice1
Function or property has platform type◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

Base automatically changed fromasher/toolbox-dev/ci toasher/toolboxSeptember 24, 2024 21:04
You can now start, stop, and update workspaces.  Since you can startworkspaces yourself now, I marked non-ready states as unreachable, whichprevents JetBrains from overriding with their own text ("disconnected"and "connected").  So now you will be able to see "stopped", "starting",and so on.  For the ready states you will still see "disconnected" or"connected" unfortunately.  Ideally this would be a completely separatestate displayed next to the workspace state.
@code-ashercode-asherforce-pushed theasher/toolbox-dev/workspace-actions branch from36d871a to5e52f91CompareSeptember 24, 2024 21:06
@code-ashercode-asher merged commit547fdea intoasher/toolboxSep 24, 2024
6 checks passed
@code-ashercode-asher deleted the asher/toolbox-dev/workspace-actions branchSeptember 24, 2024 21:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bcpeinhardtbcpeinhardtbcpeinhardt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@code-asher@bcpeinhardt

[8]ページ先頭

©2009-2025 Movatter.jp