Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: escape ampersand and question mark in ProxyCommand#480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 7 commits intomainfromescape
Sep 13, 2024

Conversation

kylecarbs
Copy link
Member

Fixes#479.

github-actions[bot] reacted with thumbs up emoji
@slushie
Copy link

I think? will also need escaping for zsh, based on our user report.

@kylecarbs
Copy link
MemberAuthor

@slushie good catch. I need to write some tests ;p

slushie reacted with laugh emoji

@kylecarbskylecarbs changed the titlefix: escape ampersand in ProxyCommandfix: escape ampersand and question mark in ProxyCommandSep 13, 2024
Looks like the one we were using disappeared again.
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedSep 13, 2024•
edited
Loading

Qodana Community for JVM

4 new problems were found

Inspection nameSeverityProblems
Incorrect string capitalization🔶 Warning1
Usage of redundant or deprecated syntax or deprecated symbols🔶 Warning1
Redundant nullable return type🔶 Warning1
String concatenation that can be converted to string template◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

Also add some notes on characters double quotes does not handle, in casewe need to do something about them in the future.
@code-ashercode-asher merged commitdc880a3 intomainSep 13, 2024
6 checks passed
@code-ashercode-asher deleted the escape branchSeptember 13, 2024 19:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@code-ashercode-ashercode-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProxyCommand fails due to unescaped --url flag
3 participants
@kylecarbs@slushie@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp