Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Set --url in SSH config#470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 1 commit intomainfromasher/add-url
Aug 29, 2024
Merged

Set --url in SSH config#470

code-asher merged 1 commit intomainfromasher/add-url
Aug 29, 2024

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedAug 27, 2024•
edited
Loading

This fixes an issue where you haveCODER_URL in your environment but then connect to a different URL. The plugin will configure the settings file, but the cli will ignore it in favor of the environment variable. The flag is always preferred, so setting that ensures we use the right URL.

Unit tests show it gets added at least, but sure would be nice if we could test the flow. For now I manually setCODER_URL to something bogus when launching Gateway (likehttp://localhost:1234) then added a new connection as normal to dev.coder.com.

github-actions[bot] and kevinh-canva reacted with thumbs up emoji
@code-ashercode-asherforce-pushed theasher/add-url branch 2 times, most recently fromd18593d todead511CompareAugust 27, 2024 23:28
@code-ashercode-asher marked this pull request as ready for reviewAugust 27, 2024 23:33
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedAug 27, 2024•
edited
Loading

Qodana Community for JVM

4 new problems were found

Inspection nameSeverityProblems
Incorrect string capitalization🔶 Warning1
Usage of redundant or deprecated syntax or deprecated symbols🔶 Warning1
Redundant nullable return type🔶 Warning1
String concatenation that can be converted to string template◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

@code-ashercode-asher merged commit4cb1177 intomainAug 29, 2024
6 checks passed
@code-ashercode-asher deleted the asher/add-url branchAugust 29, 2024 17:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bcpeinhardtbcpeinhardtAwaiting requested review from bcpeinhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp