Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: use background hostname for admin tasks#446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 10 commits intomainfromf0ssel/disable-tracking
Jun 25, 2024

Conversation

f0ssel
Copy link
Collaborator

This adds a newgetBackgroundHostName() func that is intended to be used for all SSH connections that are not the main IDE connection. This prevents background admin actions using SSH to trigger usage tracking for the workspace.

github-actions[bot] reacted with thumbs up emoji
Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good!

Should we use the background host name for this one too?

.command("ssh","-t", workspace.hostname,"cd '${workspace.idePathOnHost}' ; cd bin ;$command")

It is responsible for running the setup command (users use it to preinstall plugins, mainly) before connecting to the IDE.

@f0sself0sselforce-pushed thef0ssel/disable-tracking branch from1bed23e to632e12aCompareJune 25, 2024 18:21
Base automatically changed fromf0ssel/usage-app tomainJune 25, 2024 18:40
@f0sself0sselforce-pushed thef0ssel/disable-tracking branch fromb8e0e29 tocf673a1CompareJune 25, 2024 18:59
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedJun 25, 2024•
edited
Loading

Qodana Community for JVM

3 new problems were found

Inspection nameSeverityProblems
Incorrect string capitalization🔶 Warning1
Redundant nullable return type🔶 Warning1
String concatenation that can be converted to string template◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

@f0sself0ssel requested a review fromcode-asherJune 25, 2024 19:10
@f0ssel
Copy link
CollaboratorAuthor

@code-asher thanks for catching these other cases! I've updated the PR with those changes as well as got the tests all passing.

code-asher reacted with rocket emoji

Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me!

@f0sself0ssel merged commit3e927ba intomainJun 25, 2024
6 checks passed
@f0sself0ssel deleted the f0ssel/disable-tracking branchJune 25, 2024 21:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@code-ashercode-ashercode-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@f0ssel@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp