coder/jetbrains-coderPublic

NotificationsYou must be signed in to change notification settings
Fork16
Star34

chore: pass usage app name to coder ssh#442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

f0ssel merged 6 commits intomainfromf0ssel/usage-app

Jun 25, 2024

Merged

chore: pass usage app name to coder ssh#442

f0ssel merged 6 commits intomainfromf0ssel/usage-app

Jun 25, 2024

Conversation

Copy link

Collaborator

f0ssel commentedJun 22, 2024•
edited
Loading

Relies oncoder/coder#13637.

This signals to the CLI to track workspace usage with thejetbrains usage app name.

chore: pass usage app name to coder ssh

adbe5a6

f0ssel requested a review fromcode-asher

June 22, 2024 23:14

Copy link

CollaboratorAuthor

f0ssel commentedJun 22, 2024•
edited
Loading

Both locally and in CI I'm seeing this fail to build with the following error:

> Could not find com.jetbrains.gateway:JetBrainsGateway:233.14808-EAP-CANDIDATE-SNAPSHOT.
https://github.com/coder/jetbrains-coder/actions/runs/9628941608/job/26557738545?pr=442#step:5:329

Update:
Updating the version to233.15325-EAP-CANDIDATE-SNAPSHOT seemed to fix it.

f0ssel mentioned this pull request

Jun 24, 2024

Refactor APIs to unify workspace activitycoder/coder#13279

Closed

14 tasks

try new EAP version

82849ba

Copy link

Contributor

github-actionsbot commentedJun 24, 2024•
edited
Loading

Qodana Community for JVM

2 new problems were found

Inspection name	Severity	Problems
`Incorrect string capitalization`	🔶 Warning	1
`Redundant nullable return type`	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register atQodana Cloud andconfigure the action
UseGitHub Code Scanning with Qodana
HostQodana report at GitHub Pages
Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.2with:upload-result:true

Contact Qodana team

Or via our issue tracker:https://jb.gg/qodana-issue
Or share your feedback:https://jb.gg/qodana-discussions

code-asher reviewed

Jun 24, 2024

View reviewed changes

Copy link

Member

code-asher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks good to me! Though I mentioned this on the other PR but I think we will have to use the flag after all for Windows. We could check against the CLI version before adding the flag. There is some precedence for it here:

jetbrains-coder/src/main/kotlin/com/coder/gateway/cli/CoderCLIManager.kt

Lines 109 to 114 indceb578

	/**
	* The supported features of the CLI.
	*/
	data classFeatures(
	valdisableAutostart:Boolean =false,
	)

jetbrains-coder/src/main/kotlin/com/coder/gateway/cli/CoderCLIManager.kt

Lines 447 to 448 indceb578

	// Autostart with SSH was added in 2.5.0.
	disableAutostart= version>=SemVer(2,5,0),

f0ssel added4 commits

June 25, 2024 14:55

use flag over env var

5b12758

space

881a41b

newline

8338d19

feature tests

329ee12

f0ssel requested a review fromcode-asher

June 25, 2024 15:25

Copy link

CollaboratorAuthor

f0ssel commentedJun 25, 2024

@code-asher I've updated it to check the version and use the flag, thanks for the catch on the windows compatibility.

code-asher approved these changes

Jun 25, 2024

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome!!

f0ssel merged commit950c3b1 intomain

Jun 25, 2024

f0ssel deleted the f0ssel/usage-app branch

June 25, 2024 18:40

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: pass usage app name to coder ssh#442

chore: pass usage app name to coder ssh#442

Uh oh!

Conversation

f0ssel commentedJun 22, 2024•
edited
Loading

Uh oh!

Uh oh!

f0ssel commentedJun 22, 2024•
edited
Loading

Uh oh!

Uh oh!

github-actionsbot commentedJun 24, 2024•
edited
Loading

Uh oh!

Qodana Community for JVM

Uh oh!

code-asher left a comment•
edited
Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

f0ssel commentedJun 25, 2024

Uh oh!

code-asher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Movatterモバイル変換

chore: pass usage app name to coder ssh#442

chore: pass usage app name to coder ssh#442

Uh oh!

Conversation

f0ssel commentedJun 22, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

f0ssel commentedJun 22, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

github-actionsbot commentedJun 24, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Qodana Community for JVM

Uh oh!

code-asher left a comment• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

f0ssel commentedJun 25, 2024

Uh oh!

code-asher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

f0ssel commentedJun 22, 2024•
edited
Loading

f0ssel commentedJun 22, 2024•
edited
Loading

github-actionsbot commentedJun 24, 2024•
edited
Loading

code-asher left a comment•
edited
Loading