coder/jetbrains-coderPublic

NotificationsYou must be signed in to change notification settings
Fork16
Star34

Add the ability to disable autostart#366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

code-asher merged 3 commits intomainfromasher/disable-autostart

Feb 23, 2024

Merged

Add the ability to disable autostart#366

code-asher merged 3 commits intomainfromasher/disable-autostart

Feb 23, 2024

Conversation

Copy link

Member

code-asher commentedFeb 23, 2024•
edited
Loading

On macOS this is checked by default for 2.5.0 and above.

Closes#365

code-asher requested a review fromjohnstcn

February 23, 2024 01:12

code-asher force-pushed theasher/disable-autostart branch fromcd2c457 to47c9805Compare

February 23, 2024 01:19

Copy link

Contributor

github-actionsbot commentedFeb 23, 2024•
edited
Loading

Qodana Community for JVM

47 new problems were found

Inspection name	Severity	Problems
`Unused symbol`	🔶 Warning	26
`Unstable API Usage`	🔶 Warning	8
`Incorrect string capitalization`	🔶 Warning	7
`Redundant qualifier name`	🔶 Warning	2
`Call to 'equals()' or 'hashCode()' on 'URL' object`	🔶 Warning	2
`Redundant semicolon`	🔶 Warning	1
`Redundant empty primary constructor`	◽️ Notice	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register atQodana Cloud andconfigure the action
UseGitHub Code Scanning with Qodana
HostQodana report at GitHub Pages
Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.0with:upload-result:true

Contact Qodana team

Or via our issue tracker:https://jb.gg/qodana-issue
Or share your feedback:https://jb.gg/qodana-discussions

code-asher force-pushed theasher/disable-autostart branch from47c9805 to1550453Compare

February 23, 2024 01:21

Add the ability to disable autostart

7c4fcaf

On macOS this is checked by default for 2.5.0 and above.

code-asher force-pushed theasher/disable-autostart branch from1550453 to7c4fcafCompare

February 23, 2024 01:22

johnstcn assignedcode-asher

Feb 23, 2024

johnstcn approved these changes

Feb 23, 2024

View reviewed changes

Copy link

Member

johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some suggestions, but LGTM apart from that.

CHANGELOG.md OutdatedShow resolvedHide resolved

src/main/kotlin/com/coder/gateway/cli/CoderCLIManager.kt Outdated

Comment on lines 205 to 206

		funconfigSsh(workspaceNames:List<String>,version:SemVer? = tryVersion()) {
		writeSSHConfig(modifySSHConfig(readSSHConfig(), workspaceNames, version))

Copy link

Member

johnstcnFeb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggestion: refactor toconfigSsh(options: configSSHOptions) where options consists of

  workspaceNames: List<String>  disableAutostart: boolean

This allows you to then simplify the logic in line 235 to

if (opts.disable-autostart) "--disable-autostart" else null

and move the version checking logic outside ofmodifySSHConfig()

Copy link

MemberAuthor

code-asherFeb 23, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was thinking of something like this! But then it felt weird because sometimes we would use the settings (for header command) and sometimes not (for disable autostart). Maybe asupports orfeatures object that has keys for what features are supported then I havesettings.disableAutostart && supports.disableAutostart.

Copy link

Member

johnstcnFeb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Gotcha, that would definitely make things more confusing. Not a blocker for me in any case.

src/main/kotlin/com/coder/gateway/services/CoderSettingsState.ktShow resolvedHide resolved

Add setting name in changelog

fecbe98

code-asher force-pushed theasher/disable-autostart branch 2 times, most recently from38816fb to373329bCompare

February 23, 2024 18:54

Encapsulate version in checks in features object

1dece08

code-asher force-pushed theasher/disable-autostart branch from373329b to1dece08Compare

February 23, 2024 19:26

code-asher merged commit23ebb16 intomain

Feb 23, 2024

code-asher deleted the asher/disable-autostart branch

February 23, 2024 19:33

Labels

None yet

Movatterモバイル変換

Add the ability to disable autostart#366

Add the ability to disable autostart#366

Uh oh!

Conversation

code-asher commentedFeb 23, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

github-actionsbot commentedFeb 23, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Qodana Community for JVM

Uh oh!

johnstcn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

johnstcnFeb 23, 2024

Choose a reason for hiding this comment

Uh oh!

code-asherFeb 23, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnstcnFeb 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

code-asher commentedFeb 23, 2024•
edited
Loading

github-actionsbot commentedFeb 23, 2024•
edited
Loading

code-asherFeb 23, 2024•
edited
Loading