- Notifications
You must be signed in to change notification settings - Fork16
Prevent early variable expansion in header command#364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+74 −23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8fbef28 to1dd7d2cCompare1dd7d2c tof735e7aCompareQodana Community for JVM48 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.0with:upload-result:true Contact Qodana teamContact us atqodana-support@jetbrains.com
|
johnstcn approved these changesFeb 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#338.
The problem was that if your header command was something like
auth --url=$CODER_URL, it would get expanded as part of executing the proxy command and you end up withauth --url=sinceCODER_URLis not set.We want to pass it literally to the binary so that it can then be expanded in the binary when it executes the header command, since the binary will set
CODER_URLwhen spawning.An alternative would be to set
CODER_URLwhen the proxy command is spawned, but I am not sure we can as I think it would be using the current process environment (via that SSHJ library I think). Maybe there is a way to mutate the current environment, but a quick look says no.