- Notifications
You must be signed in to change notification settings - Fork16
Prevent early variable expansion in header command#364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8fbef28 to1dd7d2cCompare1dd7d2c tof735e7aCompareQodana Community for JVM48 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.3.0with:upload-result:true Contact Qodana teamContact us atqodana-support@jetbrains.com
|
Uh oh!
There was an error while loading.Please reload this page.
Fixes#338.
The problem was that if your header command was something like
auth --url=$CODER_URL, it would get expanded as part of executing the proxy command and you end up withauth --url=sinceCODER_URLis not set.We want to pass it literally to the binary so that it can then be expanded in the binary when it executes the header command, since the binary will set
CODER_URLwhen spawning.An alternative would be to set
CODER_URLwhen the proxy command is spawned, but I am not sure we can as I think it would be using the current process environment (via that SSHJ library I think). Maybe there is a way to mutate the current environment, but a quick look says no.