Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix recently opened workspaces not being saved#337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 1 commit intomainfromasher/fix-recents
Dec 7, 2023

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedDec 7, 2023
edited
Loading

From what I understand when you use BaseState you are supposed to use delegation. Something must have changed because this code used to work just as it was, but now it seems without delegation the properties are ignored and we were getting recent entries that were blank (looked like this:<RecentWorkspaceConnection />).

It does not appear possible to use delegation with a data class so I had to make a separate constructor.

Closes#304

github-actions[bot] reacted with thumbs up emoji
From what I understand when you use BaseState you are supposed to usedelegation.  Something must have changed because this code used to workjust as it was, but now it seems without delegation the properties areignored and we were getting recent entries that were blank (looked likethis: `<RecentWorkspaceConnection />`).
@github-actionsGitHub Actions
Copy link
Contributor

Qodana Community for JVM

54 new problems were found

Inspection nameSeverityProblems
Unused symbol🔶 Warning29
Unstable API Usage🔶 Warning8
Incorrect string capitalization🔶 Warning7
Call to 'equals()' or 'hashCode()' on 'URL' object🔶 Warning2
Local 'var' is never modified and can be declared as 'val'🔶 Warning1
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9🔶 Warning1
Redundant semicolon🔶 Warning1
Useless call on not-null type🔶 Warning1
Function naming convention◽️ Notice1
Class member can have 'private' visibility◽️ Notice1
Size check can be replaced with 'isNotEmpty()'◽️ Notice1
Trailing comma recommendations◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.2.8with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

@code-ashercode-asher merged commit68ff70c intomainDec 7, 2023
@code-ashercode-asher deleted the asher/fix-recents branchDecember 7, 2023 21:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@code-ashercode-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

recently opened workspaces empty on Gateway restart
2 participants
@code-asher@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp