Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove HostName from SSH config#336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 1 commit intomainfromasher/remove-hostname
Dec 7, 2023
Merged

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedDec 7, 2023•
edited
Loading

HavingHostName causes errors in Gateway about the host not being found even though it seems to work in the end...but all those (many, many) errors make the logs noisy and maybe this is causing some instability in some cases.

I have no idea why Gateway is trying to connect toHostName when there is aProxyCommand but it smells like a bug.

For now I removedHostName and there are no more errors. It was just copied from how the Coder CLI does things so hopefully it is not actually required somehow because I have no idea why it was included in the first place. Everything works for me without it.

github-actions[bot] reacted with thumbs up emoji
It is not necessary because the proxy command is what is in control hereand having HostName causes errors in Gateway about the host not beingfound even though it seems to work in the end.
@github-actionsGitHub Actions
Copy link
Contributor

Qodana Community for JVM

54 new problems were found

Inspection nameSeverityProblems
Unused symbol🔶 Warning29
Unstable API Usage🔶 Warning8
Incorrect string capitalization🔶 Warning7
Call to 'equals()' or 'hashCode()' on 'URL' object🔶 Warning2
Local 'var' is never modified and can be declared as 'val'🔶 Warning1
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9🔶 Warning1
Redundant semicolon🔶 Warning1
Useless call on not-null type🔶 Warning1
Function naming convention◽️ Notice1
Class member can have 'private' visibility◽️ Notice1
Size check can be replaced with 'isNotEmpty()'◽️ Notice1
Trailing comma recommendations◽️ Notice1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register atQodana Cloud andconfigure the action
  2. UseGitHub Code Scanning with Qodana
  3. HostQodana report at GitHub Pages
  4. Inspect and useqodana.sarif.json (seethe Qodana SARIF format for details)

To get*.log files or any other Qodana artifacts, run the action withupload-result option set totrue,
so that the action will upload the files as the job artifacts:

      -name:'Qodana Scan'uses:JetBrains/qodana-action@v2023.2.8with:upload-result:true
Contact Qodana team

Contact us atqodana-support@jetbrains.com

@code-ashercode-asher merged commit71086c9 intomainDec 7, 2023
@code-ashercode-asher deleted the asher/remove-hostname branchDecember 7, 2023 21:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@code-asher@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp